474629 - Crash in [@ nsFilePicker::GetLocalFiles] when trying to upload a file

Status: RESOLVED WORKSFORME

(Core :: Widget: Cocoa, defect)

Description

[Marcia Knous [:marcia]]

Seen while running yesterday's nightly Shiretoko build, Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3pre) Gecko/20090120 Shiretoko/3.1b3pre

STR:
1. I was uploading a file to carbonmade.com (you need to have an account to upload)
2. While the filepicker was open, it was behaving stubbornly similar to the issues reported in Bug 473467.
3. I got frustrated and kept clicking on the "Open" button to try to get the file in the upload spot and then the crash happened.

Breakpad: http://crash-stats.mozilla.com/report/index/6e85791d-23df-472e-8e82-da5df2090120

Have not yet been able to reproduce this bug.

Comment 1

[Samuel Sidler (old account; do not CC)]

Just so we don't lose it from Socorro...

Crashing Thread
Frame 	Module 	Signature 	Source
0 	libobjc.A.dylib 	libobjc.A.dylib@0x15688 	
1 	AppKit 	AppKit@0x22445b 	
2 	AppKit 	AppKit@0x10f1a2 	
3 	XUL 	-[NSWindow(MethodSwizzling) nsCocoaWindow_NSWindow_sendEvent:] 	widget/src/cocoa/nsCocoaWindow.mm:2157
4 	AppKit 	AppKit@0xdbd48 	
5 	AppKit 	AppKit@0x27da18 	
6 	AppKit 	AppKit@0x27812c 	
7 	AppKit 	AppKit@0x269219 	
8 	XUL 	nsFilePicker::GetLocalFiles(nsString const&, int, nsCOMArray<nsILocalFile>&) 	widget/src/cocoa/nsFilePicker.mm:265
9 	XUL 	nsFilePicker::Show(short*) 	widget/src/cocoa/nsFilePicker.mm:205
10 	XUL 	nsFileControlFrame::MouseListener::MouseClick(nsIDOMEvent*) 	layout/forms/nsFileControlFrame.cpp:351
11 	XUL 	nsEventListenerManager::HandleEvent(nsPresContext*, nsEvent*, nsIDOMEvent**, nsPIDOMEventTarget*, unsigned int, nsEventStatus*) 	content/events/src/nsEventListenerManager.cpp:184
12 	XUL 	nsEventTargetChainItem::HandleEvent(nsEventChainPostVisitor&, unsigned int, int) 	content/events/src/nsEventDispatcher.cpp:236
13 	XUL 	nsEventTargetChainItem::HandleEventTargetChain(nsEventChainPostVisitor&, unsigned int, nsDispatchingCallback*, int) 	content/events/src/nsEventDispatcher.cpp:300
14 	XUL 	nsEventTargetChainItem::HandleEventTargetChain(nsEventChainPostVisitor&, unsigned int, nsDispatchingCallback*, int) 	content/events/src/nsEventDispatcher.cpp:354
15 	XUL 	nsEventDispatcher::Dispatch(nsISupports*, nsPresContext*, nsEvent*, nsIDOMEvent*, nsEventStatus*, nsDispatchingCallback*) 	content/events/src/nsEventDispatcher.cpp:514
16 	XUL 	PresShell::HandleEventInternal(nsEvent*, nsIView*, nsEventStatus*) 	layout/base/nsPresShell.cpp:5935
17 	XUL 	PresShell::HandleEventWithTarget(nsEvent*, nsIFrame*, nsIContent*, nsEventStatus*) 	layout/base/nsPresShell.cpp:5840
18 	XUL 	nsEventStateManager::CheckForAndDispatchClick(nsPresContext*, nsMouseEvent*, nsEventStatus*) 	content/events/src/nsEventStateManager.cpp:3944
19 	XUL 	nsEventStateManager::PostHandleEvent(nsPresContext*, nsEvent*, nsIFrame*, nsEventStatus*, nsIView*) 	content/events/src/nsEventStateManager.cpp:2891
20 	XUL 	PresShell::HandleEventInternal(nsEvent*, nsIView*, nsEventStatus*) 	layout/base/nsPresShell.cpp:5956
21 	XUL 	PresShell::HandlePositionedEvent(nsIView*, nsIFrame*, nsGUIEvent*, nsEventStatus*) 	layout/base/nsPresShell.cpp:5823
22 	XUL 	PresShell::HandleEvent(nsIView*, nsGUIEvent*, nsEventStatus*) 	layout/base/nsPresShell.cpp:5683
23 	XUL 	nsViewManager::HandleEvent(nsView*, nsPoint, nsGUIEvent*, int) 	view/src/nsViewManager.cpp:1376
24 	XUL 	nsViewManager::DispatchEvent(nsGUIEvent*, nsEventStatus*) 	view/src/nsViewManager.cpp:1335
25 	XUL 	HandleEvent 	view/src/nsView.cpp:167
26 	XUL 	nsChildView::DispatchEvent(nsGUIEvent*, nsEventStatus&) 	widget/src/cocoa/nsChildView.mm:1988
27 	XUL 	nsChildView::DispatchWindowEvent(nsGUIEvent&) 	widget/src/cocoa/nsChildView.mm:2001
28 	XUL 	-[ChildView mouseUp:] 	widget/src/cocoa/nsChildView.mm:3602
29 	AppKit 	AppKit@0x10f240 	
30 	XUL 	-[NSWindow(MethodSwizzling) nsCocoaWindow_NSWindow_sendEvent:] 	widget/src/cocoa/nsCocoaWindow.mm:2157
31 	XUL 	-[ToolbarWindow sendEvent:] 	widget/src/cocoa/nsCocoaWindow.mm:1916
32 	AppKit 	AppKit@0xdbd48 	
33 	AppKit 	AppKit@0x3969e 	
34 	XUL 	nsAppShell::Run() 	widget/src/cocoa/nsAppShell.mm:693
35 	XUL 	nsAppStartup::Run() 	toolkit/components/startup/src/nsAppStartup.cpp:192
36 	XUL 	XRE_main 	toolkit/xre/nsAppRunner.cpp:3279
37 	firefox-bin 	main 	browser/app/nsBrowserApp.cpp:156
38 	firefox-bin 	firefox-bin@0x1541 	
39 	firefox-bin 	firefox-bin@0x1468 	
40 		@0x2

Comment 2

[Steven Michaud [:smichaud] (Retired)]

As I explained to Marcia and Sam on irc, this crash is in system code,
and I can't make much of it.

(widget/src/cocoa/nsCocoaWindow.mm:2157 is (in effect)
nsCocoaWindow_NSWindow_sendEvent:'s call to super -- i.e. to the
system method ([NSWindow sendEvent:]) that it "hooks", or
"subclasses".)

Without additional information (which we're unlikely to get, I think),
this bug can only be resolved in tandem with bug 473467.  But it isn't
exactly a dup, so I'm not making it one.

Marcia didn't see anything relevant in the system console.

Comment 3

[Steven Michaud [:smichaud] (Retired)]

Marcia:

Going through the list of modules from your crash log, I notice that
LiveType is running (in fact the module is loaded twice).

I know it's a stretch, but I wonder if bug 473467 would go away if you
(temporarily) disabled LiveType.  Apparently it gets installed with
Final Cut Pro.

Comment 4

[Marcia Knous [:marcia]]

I have Final Cut Express on the machine, so I will investigate a way to remove LiveType form the machine.

Comment 5

[Mounir Lamouri (:mounir)]

Marking WFM given that there have been no update in 2.5 years, bug 473467 has been fixed and a consequent part of GetLocalFiles have recently been rewritten.