474630 - Alarms don't work for recurring events

Status: RESOLVED FIXED

(Calendar :: Alarms, defect)

Description

[Stefan Sitter [:ssitter]]

Lightning 1.0pre (20090121) with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090121 Shredder/3.0b2pre

Steps to Reproduce:
1. Create a non-repeating event with alarm for yesterday
2. Create a repeating event with alarm for yesterday

Actual Results:
Only the alarm for the non-repeating event fires. Only the non-repeating event box shows the alarm icon in the view.

Expected Results:
Alarms work for recurring events.

Additional Information:
Using default Home calendar.

Comment 1

[Stefan Sitter [:ssitter]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090121 Calendar/1.0pre (BuildID: 20090121080753)

Doesn't work for ics provider too.

Comment 2

[Stefan Sitter [:ssitter]]

Regression range: Works in Sunbird 1.0pre (2009-01-16-01-39-17)
                  Fails in Sunbird 1.0pre (2009-01-16-02-23-51)

Checkins: https://hg.mozilla.org/comm-central/pushloghtml?startdate=2009-01-16+01:30&enddate=2009-01-16+02:30

Regressed by Bug 471973.

I just saw that Bug 474275 covers a similar issue. However: The issue still exists using the latest hourly build (2009-01-21-12-54-20)) for at least storage and ics provider.

Comment 4

[Philipp Kewisch [:Fallen][☁️📆]]

Note to self: make sure dismissing alarms works when fixing this bug.

Comment 7

[Philipp Kewisch [:Fallen][☁️📆]]

Attachment: Fix - v1

A patch like this will fix it, but I'm checking in the other alarm patches first.

Comment 8

[Philipp Kewisch [:Fallen][☁️📆]]

Comment on attachment 359746 [details] [diff] [review]
Fix - v1

After patches from bug 353492 have landed, only changes from the second file need to be added. Please review.

Comment 9

[Daniel Boelzle [:dbo]]

Comment on attachment 359746 [details] [diff] [review]
Fix - v1

This way you can't unset an alarm of a single occurrence of a recurring series which has an alarm set (at the master).

Comment 10

[Daniel Boelzle [:dbo]]

Attachment: patch - v1

This patch should fix the problem.

Comment 11

[Philipp Kewisch [:Fallen][☁️📆]]

Comment on attachment 359774 [details] [diff] [review]
patch - v1

Thanks for taking care, r=philipp

Comment 12

[Philipp Kewisch [:Fallen][☁️📆]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/04ca96e53fe2>

-> FIXED

Comment 13

[Philipp Kewisch [:Fallen][☁️📆]]

These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".