474667 - controller.type doesn't fire oninput events

Status: VERIFIED FIXED

(Testing Graveyard :: Mozmill, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Failing test

Sorry, when I cannot describe it in detail but Marco can help out here.

As what I've seen today is, that when you use controller.type to change the title of a bookmark inside the editBookmarksPanel the title is not updated. As what Marco said, we have to use oninput to propagate the event.

I'll attach a MozMill test which has to be run with the latest trunk build of MozMill. Otherwise it will not run.

Comment 1

[Marco Bonardo [:mak]]

editBMPanel_namepicker is an editable menulist, with an oninput listener.
oninput the content of the list is saved to another element that we use to save the title.
i can't see oninput handler called when type sets the value of this element, while i definately see it when manually typing.

Comment 2

[Adam Christian]

Type simply doesn't fire oninput at all because I didn't know that listener even existed, ill try adding it this afternoon and see how this should work.

Comment 3

[Adam Christian]

Apparently controller.menus.bookmarksMenu.menu_bookmarkThisPage is no longer in the code base, can someone give me this code so that I can work on this and see if I can add the oninput event to type?

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Adam, you have to use a trunk nightly build to be able to run this test. It will not work with Shiretoko right now. If you are using such a build you should see the problem.

Comment 5

[Adam Christian]

Ah thats the issue, okay thanks.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Adam, any progress on this bug so far?

Comment 7

[Adam Christian]

This should now be fixed in trunk.Committed revision 361.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Looks good. Is it something we can get for the 1.0.3 release?

Comment 9

[Adam Christian]

Thats a mikeal question, I had to monkey around with all this code again, can you re-verify?

Comment 10

[Mikeal Rogers [:mikeal] (mrogers@)]

We're shooting to get 1.1 out this week so I don't think we'll be pushing out another 1.0.x release before that.

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to comment #9)
> Thats a mikeal question, I had to monkey around with all this code again, can
> you re-verify?

Yeah. That looks fantastic! Both methods (open, and type) are working now. Thanks! If I should find regressions I'll open a follow-up bug.