Closed
Bug 474692
Opened 16 years ago
Closed 16 years ago
onbeforeunload fired twice when using Close Window menuitem or Accel+Shift+W
Categories
(Firefox :: Menus, defect, P2)
Tracking
()
VERIFIED
WORKSFORME
Firefox 3.5
People
(Reporter: mconnor, Assigned: mconnor)
Details
Attachments
(1 file)
|
809 bytes,
patch
|
Details | Diff | Splinter Review |
We call BrowserTryToCloseWindow twice in this particular case. Not sure how long this has been the case, but doing this twice is a pretty annoying bug if there's a prompt.
attachment 339934 [details] works for seeing the problem.
Before the fix for bug 456447, you'll get two prompts, then the close all tabs prompt. After, you'll get prompt, all tabs prompt, then prompt again. oops.
WIll fix for 3.1 final, this would be really annoying, though on a hopefully-low-use codepath...
Flags: blocking-firefox3.1+
|
Assignee | |
Updated•16 years ago
|
Priority: -- → P2
|
||
Updated•16 years ago
|
Whiteboard: [needs patch]
|
|
Assignee | |
Comment 2•16 years ago
|
||
I can't reproduce this now, maybe something else was broken. Resolving WFM. Will file a followup on another issue I found.
Status: NEW → RESOLVED
Closed: 16 years ago
Flags: blocking-firefox3.1+
Resolution: --- → WORKSFORME
|
||
Updated•16 years ago
|
Attachment #364189 -
Flags: review?(gavin.sharp)
|
||
Comment 3•16 years ago
|
||
Yeah, it's only fired once. Verified.
Status: RESOLVED → VERIFIED
Whiteboard: [needs patch]
Version: unspecified → 3.1 Branch
|
||
Updated•16 years ago
|
Target Milestone: Firefox 3.1 → Firefox 3.5
You need to log in
before you can comment on or make changes to this bug.
Description
•