809 bytes, patch
|Details | Diff | Splinter Review|
We call BrowserTryToCloseWindow twice in this particular case. Not sure how long this has been the case, but doing this twice is a pretty annoying bug if there's a prompt. attachment 339934 [details] works for seeing the problem. Before the fix for bug 456447, you'll get two prompts, then the close all tabs prompt. After, you'll get prompt, all tabs prompt, then prompt again. oops. WIll fix for 3.1 final, this would be really annoying, though on a hopefully-low-use codepath...
Created attachment 364189 [details] [diff] [review] remove the onclose handler after we've already checked once pretty simple...
I can't reproduce this now, maybe something else was broken. Resolving WFM. Will file a followup on another issue I found.
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → WORKSFORME
Yeah, it's only fired once. Verified.
Status: RESOLVED → VERIFIED
Whiteboard: [needs patch]
Version: unspecified → 3.1 Branch
You need to log in before you can comment on or make changes to this bug.