474747 - Change columns: empty buttons when images turned off

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[Vitaly Fedrushkov]

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/webtools/bugzilla/template/en/default/list/change-columns.html.tmpl&rev=1.19#59

 <input class="image_button" type="button" id="select_button"  
   name="select" onclick="move_select()">  
 <br><br> 

displays nothing when there are no images.

Otherwise Bugzilla is still pretty usable without images :-)

Comment 1

[Max Kanat-Alexander]

Yeah, we should put → and ← as the alt="" probably, for them.

Comment 2

[Vitaly Fedrushkov]

and invent something visual or resize for 'Up' and 'Down'

l12y note: don't rely on 'Up' or 'Down' being short words :-)

Comment 3

[Frédéric Buclin]

(In reply to comment #1)
> Yeah, we should put → and ← as the alt="" probably, for them.

Sounds good to me, assuming you can indeed pass alt="" with type="button". Not sure about that.

Comment 4

[Michael Thomas (Mockodin)]

What browser was this seen with?

I'm seeing similar (same?) issue with IE8 where the background-image being specified in global.css is not showing up.

I was able to make them show up by explicitly setting the border properties:
 border: 1px solid #6D7B8D; /* used a grey color to soften it */

However this has the effect of turning the button into ugly square boxes.
At least for FireFox adding the following will round the corners again:
-moz-border-radius: 5px;

Comment 5

[Michael Thomas (Mockodin)]

Missed the note comment on no images ( comment 0 ), but none the less my comment may be useful to someone.

Comment 6

[Frédéric Buclin]

Bugzilla 3.4 is now restricted to security bugs. We will retarget this bug (to 3.6 or later) when it's fixed.

Comment 7

[Marc Schumann [:Wurblzap]]

Attachment: Patch

Comment 8

[Frédéric Buclin]

Comment on attachment 612131 [details] [diff] [review]
Patch

>+          <input class="bz_default_hidden" type="button" id="select_button"
>+                 name="select" onclick="move_select()" value="&rarr;">

This looks good, but could it be possible to make the arrows a bit bigger? They look very thin. Either that, or do the same as we do to reclassify classifications, i.e. using text in buttons, something like "Add >>", "<< Remove", "Move Up", "Move Down".

Comment 9

[Marc Schumann [:Wurblzap]]

Attachment: Patch 1.1

Sized 'em up. I think it works out a lot better now.

I played around with ▲▶▼◀ a little, but there seem to be no HTML entities for them so I wasn't sure whether we'd depend too much on a client's installed fonts with them.

Comment 10

[Frédéric Buclin]

Comment on attachment 615046 [details] [diff] [review]
Patch 1.1

r=LpSolit

Comment 11

[Marc Schumann [:Wurblzap]]

Great, thanks.

Committing to: bzr+ssh://[e-mail]/bugzilla/4.2/
modified skins/standard/global.css
deleted skins/standard/global/down.png
deleted skins/standard/global/left.png
deleted skins/standard/global/right.png
deleted skins/standard/global/up.png
modified template/en/default/list/change-columns.html.tmpl
Committed revision 8073.

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified skins/standard/global.css
deleted skins/standard/global/down.png
deleted skins/standard/global/left.png
deleted skins/standard/global/right.png
deleted skins/standard/global/up.png
modified template/en/default/list/change-columns.html.tmpl
Committed revision 8193.