47478 - framesets inside of a iframe will not print.

Status: VERIFIED FIXED

(Core :: Printing: Output, defect, P2)

Description

[ekrock's old account (dead)]

Using Commercial 2000080304 on WinNT 4.0 SP4.

To repro:
1) visit above URL (nscp stock price for 7/31/97 at bigcharts.com)
2) print

Expected: whole page prints
Actual:   only banner ad at top of page prints

Prints fine in Nav4.73.

Comment 1

[ekrock's old account (dead)]

Marking 4xp. Nominating for nsbeta3 consideration.

Comment 2

[Kevin McCluskey (gone)]

Doesn't print for me either with latest Mozilla build.

Marking nsbeta3+

Comment 3

[dcone (gone)]

IFrame printing problem.. I will research this a little before I make more 
recommendations..

Comment 4

[dcone (gone)]

This is a problem with IFrames.

Comment 5

[Kevin McCluskey (gone)]

Setting Priority to P1

Comment 6

[dcone (gone)]

*** Bug 49621 has been marked as a duplicate of this bug. ***

Comment 7

[Kevin McCluskey (gone)]

Setting priority to P3 based on new criteria.

Summary: Any page with an Iframe will only print the contents of the iframe. The 
page content will not print.

Comment 8

[dcone (gone)]

*** Bug 51397 has been marked as a duplicate of this bug. ***

Comment 9

[Kevin McCluskey (gone)]

Taking bug from Don to investigate.

Comment 10

[ekrock's old account (dead)]

Increasing priority to P2 because this is a high profile existing web content 
backward compatibility issue. Existing web content is already using IFRAMEs for 
advertising banners (which are not exactly rare on the web!), and both Nav4 and 
IE4/5 print such pages correctly.

Comment 11

[Kevin McCluskey (gone)]

Reassigning to rods.

Comment 12

[rods (gone)]

Attachment: diff -u patch file, patch from dir mozilla/layout

Comment 13

[selmer (gone)]

pdt agrees p2.

Comment 14

[rods (gone)]

Attachment: patching just nsDocumentViewer.cpp

Comment 15

[rods (gone)]

fixed

Comment 16

[Blake Ross]

really marking fixed, as I assume rod meant to do.

Comment 17

[shrirang khanzode]

I tried this with today's build on windows. (2000092212m18). What prints is : 
The ad banner on top leaving the rest of the page blank.Another page with the ad 
banner again with the rest of the page blank and then the third page with the 
rest of the page' content. Ideally all of this should print on one page (as seen 
on the webpage). Try printing the testcase linked below.It prints a blank page 
and then the contents of the page.

http://bugzilla.mozilla.org/showattachment.cgi?attach_id=13439

Reopening this bug. Problem is a still bad one.

Comment 18

[rods (gone)]

This is probably related to bug 54004

Comment 19

[Peter Trudelle]

PDT marking nsbeta3-, could even live with for RTM.

Comment 20

[rods (gone)]

This is was partially fixed for nsbeta3, and at that time there was debate as to 
whether we should search just the first level of children or the entire tree. I 
checked in the fix with just a "breadth" search of the first level, but sine 
then we have decided that we should need to search the entire tree until we it a 
FrameSet. Although this may not be very fast, it occurs only once during 
the printing of the document.

Without this fix it will not print a frameset inside of a iframe. The risk is 
low because it  was part of our earilier discussions and testing.

Comment 21

[rods (gone)]

reasigning to don

Comment 22

[dcone (gone)]

I don't think this will be something that will be that useful.. for this 
release..and may unstabalize the printing.

Comment 23

[ekrock's old account (dead)]

Could you clarify what you mean by "not that useful for this release"? It's sure  
useful (necessary!) if you want to print stock charts from bigcharts.com! ;->

Of course, importance and risk are two independent issues. Perhaps you're really 
more concerned about the potential risk of destabilizing the code? Further 
detail on the risk you perceive would be great.

Comment 24

[dcone (gone)]

Adding the recursive abilty to print these nested documents I think would make 
things a little unstable for the amount of payoff we would achieve.  I think (I 
could be wrong) that there are not that many documents with IFrames inside of 
Framesets.  The part that IFrames print inside of a basic document is fixed.

Comment 25

[shrirang khanzode]

keyword: rtm

Comment 26

[Kevin McCluskey (gone)]

CC'ing Rod.
Rod, you added code that fixed a problem where we weren't printing the parent
document if it contained an iframe. I believe the code you added allows us to
distinguish between body documents and frameset documents. Can we make use of
this to recursively descend into iframes and print their contents which may
include frameset documents?

Marking [rtm need info]

Comment 27

[Kevin McCluskey (gone)]

Rod: Disregard my last question, I just read your previous comment which answers
my question.

How much work/risk would it be to do a search for all framesets/iframes and
print them?

Reassigning to Rod.

Comment 28

[rods (gone)]

This is a known problem and thought dcone already had a bug on this?

Comment 29

[Kevin McCluskey (gone)]

With todays build it prints the entire page at bigcharts. I think this bug has
morphed into a special case which we do not have a test case for.

Marking rtm-, unless we can find a major site where this causes a problem.

Comment 30

[rods (gone)]

sending this back to dcone as a futured bug

Comment 31

[dcone (gone)]

*** Bug 53296 has been marked as a duplicate of this bug. ***

Comment 32

[shrirang khanzode]

spam : changing qa to sujay (new qa contact for Printing)

Comment 33

[dcone (gone)]

Fixed

Comment 34

[sujay]

verified in 2/26 build.