Open Bug 474800 Opened 15 years ago Updated 1 year ago

leaktest logs include unknown event types

Categories

(Testing :: General, defect)

Product:
Testing
Component:
General
Type:
defect

Tracking

(Not tracked)

People

(Reporter: ted, Unassigned)

References

(
URL
)

Details

(Whiteboard: [unittest][automation])

Attachments

(1 file)

Like so? (landed on m-c)
749 bytes, patch
dbaron
: review+
Details | Diff | Splinter Review 
The leaktest builds run "leakstats" to process the leak logs. In the linked URL, leakstats failed because there was a garbage character in the output. Apparently the buildbot code fails in this case, because there's a buildbot traceback in that log as well. The code should be resilient to failure there.
I poked around a few recent mozilla-191, m-c leaktest builds on tinderbox, and the URLs all seemed ok to me, afaict. Could you give more details, or an example? 

Also, how often does this happen?
Component: Release Engineering → Release Engineering: Future
What do you mean by "the URLs seemed OK"? The problem here is that leakstats fails to parse a log and Buildbot doesn't handle that failure properly.
Mass move of bugs from Release Engineering:Future -> Release Engineering. See
http://coop.deadsquid.com/2010/02/kiss-the-future-goodbye/ for more details.
Component: Release Engineering: Future → Release Engineering
Priority: -- → P3
Is this the problem showing up here? http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1270669786.1270670987.7106.gz&fulltext=1

obj-firefox/dist/bin/leakstats starting at Wed Apr  7 13:01:22 2010
Unknown event type �
obj-firefox/dist/bin/leakstats: log file incomplete
program finished with exit code 1
elapsedTime=0.156451
Unable to parse leakstats output
The tinderbox logs contain control characters like DLE or '\x10' or ^P depending on your editor encoding. Also the ^J characters.

One such example is "Unknown event type '\x10' " in the following tinderbox json chunk.  Don't try to load it into FF, it crashes FF, use wget to get the chunk and search for the ^P character at 113725

json chunk URL : http://tinderbox.mozilla.org/showbuilds.cgi?tree=Firefox&maxdate=1270595773&noignore=1&hours=24&json=1
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1271274291.1271280033.27898.gz
OS X 10.6.2 mozilla-central leak test build on 2010/04/14 12:44:51  
s: moz2-darwin10-slave17

Appears to be the same thing as mwu describes in comment 4.  Murali, firefox doesn't crash for me loading the log ....
This should fix the "Unknown event" garbage in comment 4, I think.
Attachment #439117 - Flags: review?(dbaron)
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1271736599.1271737888.7795.gz
OS X 10.5 comm-central-trunk leak test build on 2010/04/19 21:09:59
{
Unknown event type �
objdir/mozilla/dist/bin/leakstats: log file incomplete
program finished with exit code 1
}
http://tinderbox.mozilla.org/showlog.cgi?log=Thunderbird/1271741527.1271742608.18076.gz
MacOSX 10.5 comm-central bloat on 2010/04/19 22:32:07
{
Unknown event type p
objdir-tb/mozilla/dist/bin/leakstats: log file incomplete
program finished with exit code 1
}
Comment on attachment 439117 [details] [diff] [review]
Like so? (landed on m-c)

r=dbaron if you cast to (unsigned int) instead, since that's what %x is.
Attachment #439117 - Flags: review?(dbaron) → review+
Comment on attachment 439117 [details] [diff] [review]
Like so? (landed on m-c)

http://hg.mozilla.org/mozilla-central/rev/8102627c8c62
with nit above.
Attachment #439117 - Attachment description: Like so? → Like so? (landed on m-c)
Anything else to do here?
"Buildbot doesn't handle that failure properly" in comment 2?
Investigate the cause of the "Unknown event type"?
Hard to tell what actually happened for comment 0 at this point, but that part's probably fixed, since there's no buildbot traceback anymore. However, investigating the cause certainly seems like a good idea.

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1272448281.1272456333.27442.gz
WINNT 5.2 mozilla-central leak test build on 2010/04/28 02:51:21
s: mw32-ix-slave11

Unknown event type 0xffffffed
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1272455054.1272462390.32248.gz
WINNT 5.2 mozilla-central leak test build on 2010/04/28 04:44:14
s: mw32-ix-slave07

Unknown event type 0xffffffed
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1273171003.1273177894.21703.gz
WINNT 5.2 mozilla-central leak test build on 2010/05/06 11:36:43
s: mw32-ix-slave02
Priority: P3 → P5
Should this be reclassified under Testing:General to figure out what the "Unknown event type" are?
Whiteboard: [unittest][automation]
As good a place as any.
Component: Release Engineering → General
Priority: P5 → --
Product: mozilla.org → Testing
QA Contact: release → general
Summary: leaktest builds don't handle leakstats failure → leaktest logs include unknown event types
Version: other → Trunk
Depends on: 539334
No longer blocks: debug_builds
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.