474842 - SHOWFOR browser detection is not working

Status: VERIFIED FIXED

(support.mozilla.org :: Knowledge Base Software, task)

Description

[Chris Ilias [:cilias]]

Going to any KB article that uses SHOWFOR for different versions of Firefox, no version is detected or selected as default. This hides any content that is specific to any version.
For instance, going to <http://support.mozilla.com/kb/The+bookmarks+and+history+system+will+not+be+functional?bl=n> displays no content at all.
The section underneath "Removing bookmarks results from the list" of <http://support.mozilla.com/kb/Hiding+bookmarks+in+the+Smart+Location+Bar?bl=n> is not displayed.
And no version is bolded underneath "Show content customized for:"

There articles are receiving lots of comments from users complaining about not seeing anything.

Comment 1

[Chris Ilias [:cilias]]

Tested on:
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.0.4) Gecko/2008102920 Firefox/3.0.4

Comment 2

[E. Cooper [:ecooper]]

Known UA failures:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.0.4)
Gecko/2008102920 Firefox/3.0.4
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.5) Gecko/2008121622
Ubuntu/8.10 (intrepid) Firefox/3.0.5
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.5) Gecko/2008120122
Firefox/3.0.5

Not sure if it's limited to just those pages or all pages using showfor. Oddly, it seems to be working on my machine even after clearing cookies a few times.

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.5) Gecko/2008121621 Ubuntu/8.04 (hardy) Firefox/3.0.5 Ubiquity/0.1.5

Comment 3

[Chris Ilias [:cilias]]

Screencast:
http://ilias.ca/sumo/2009-01-22_1502.swf

Comment 4

[[:Cww]]

Attachment: pagesource

Attaching HTML source of busted page.  The page loads, it's just all hidden.

Comment 5

[[:Cww]]

I stuck a "please select a browser version and OS" in the bookmarks and history
article.  This should be patched quick anyhow but here's a note to remove it
when it's patched and pushed.

Comment 6

[E. Cooper [:ecooper]]

Attachment: Updates showfor auto-detect code to point to correct tab and adds 3.1 detection

The auto-detection was failing because it was pointing showfor to 'firefox3' instead of 'firefox3.0'. In retrospect, this bug should have existed for the last two releases, so I'm wondering what it was only reported today.

I've updated the js to point to firefox3.0 on FF versions 3.0.X and point to firefox3.1 on FF versions 3.1.

If we could sneak this in on production ASAP, that'd be great. Showfor is a widely used feature across SUMO.

At some point, the code should be refactored to look for Firefox/X.X instead of splitting on "/".

Comment 7

[[:Cww]]

It probably wasn't a big deal because pages were still showfor=firefox3 ... only recently have their been updates to make pages that only apply to 3.0 only show 3.0 content etc.

Comment 8

[David Tenser [:djst]]

Eric, who should review this?

Comment 9

[E. Cooper [:ecooper]]

Comment on attachment 358270 [details] [diff] [review]
Updates showfor auto-detect code to point to correct tab and adds 3.1 detection

This is just a basic JS change in a very basic JS script.

Put Laura on review. If there's someone more suitable/less busy, please switch.

Comment 10

[E. Cooper [:ecooper]]

Comment on attachment 358270 [details] [diff] [review]
Updates showfor auto-detect code to point to correct tab and adds 3.1 detection

in r21978 / r21979

Stephen please test for 3.1 support as well.

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

Tested with:

==Trunk (3.2)==:
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2a1pre) Gecko/20090204 Minefield/3.2a1pre

* Got "3.0"

==3.1 candidates==:
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b3pre) Gecko/20090204 Shiretoko/3.1b3pre

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090204 Shiretoko/3.1b3pre

* Got "3.1"

==3.0.x==:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.6) Gecko/2009011913 Firefox/3.0.6

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.5) Gecko/2008120122 Firefox/3.0.5

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.5) Gecko/2008120121 Firefox/3.0.5

* Got "3.0"

==2.0.0.x==:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.20) Gecko/20081217 Firefox/2.0.0.20

* Got "2.0"