474858 - Only allow one instance to be created

Status: RESOLVED FIXED

(Other Applications Graveyard :: QA Companion, enhancement)

Description

[Aakash Desai [:aakashd]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090119 Shiretoko/3.1b3pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090119 Shiretoko/3.1b3pre

As of now, QAC allows users to run more than one unique instance of the program. Usabilities issues such as confusion due to redundancy and performance of QAC can come up due to this. Also, logically, all users are only really going to be running one test group at a time.

Reproducible: Always

Steps to Reproduce:
1. Go to Tools | QA Companion
2. Focus in back to the browser and go to Tools | QA Companion
Actual Results:  
Multiple QAC instances pop up

Expected Results:  
One QAC instance should be running and if the user clicks on Tools | QA Companion when its already running, the focus should be put back on the already running instance.

Comment 1

[Tyler Downer [He/Him]]

Seems more like an enhancement, to request a feature not currently there. Agree?

Comment 2

[Tyler Downer [He/Him]]

Hey Clint. Another QAC bug for you.

Comment 3

[cmtalbert]

It is indeed an enhancement, and one that is needed.  Thanks for CCing me on it, Tyler.

Comment 4

[Heather Arthur [:harth]]

Attachment: possible fix

when you open QAC this will either focus the currently open QAC window or open a new one if you don't have one open already.

Comment 5

[cmtalbert]

Comment on attachment 358644 [details] [diff] [review]
possible fix

>Index: chrome/content/qa.js
>===================================================================
>--- chrome/content/qa.js	(revision 21688)
>+++ chrome/content/qa.js	(working copy)
>@@ -39,8 +39,12 @@
>   htmlNS: "http://www.w3.org/1999/xhtml",
> 
>   openQATool : function() {
>-    window.open("chrome://qa/content/qa.xul", "_blank",
>-                "chrome,all,dialog=no,resizable=yes");
>+    var wm = Components.classes["@mozilla.org/appshell/window-mediator;1"]
>+              .getService(Components.interfaces.nsIWindowMediator);
Align .getService underneath the "C" not the "o". r=ctalbert with that nit.

Thanks for the patch.

Comment 6

[Heather Arthur [:harth]]

Attachment: patch updated to comment

patch with alignment fix

Comment 7

[cmtalbert]

(In reply to comment #6)
> Created an attachment (id=359197) [details]
> patch updated to comment
> 
> patch with alignment fix
Doh!  I meant to tell you that I'd just do this before I checked it in.  I'm sorry.  Next time it's such a trivial fix, just have me do it before checking in so you don't have to attach a new patch.  Thanks for the patch though, it's very helpful.

Checked in: 
svn commit -m "Bug 474858: Only one instance of QAC window should be opened patch by harthur, r=ctalbert"
Sending        chrome/content/qa.js
Sending        chrome/content/qa.xul
Transmitting file data ..
Committed revision 21842.