47497 - After sending mail get dialog that says you can't save mail to local folder the crashes

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect, P3)

Description

[Alek Jeziorek]

-start browser
-Tasks|Netscape Mail
-compose a new message by pressing on  the new message button
-send it to yourself and put whatever you want in the subject and body
-send the message
-you'll get a dialog that says: Your send operation was successful, but copying 
the message to your sent folder failed. WOuld you like to return to the 
compose window?
-press ok
-watch as it crashes
all platforms trunk m18 build 2000-08-03-08-M18

Comment 1

[Jon Granrose]

definitely holding for this one.

Comment 2

[Jean-Francois Ducarroz]

Looking at it right now...

QA, can you try to reproduce this problem, thanks

Comment 3

[Zach Lipton [:zach]]

I can reproduce this bug. I am about to attach a stdlog.

Comment 4

[Zach Lipton [:zach]]

Attachment: MacsBug stdlog of crash

Comment 5

[Jean-Francois Ducarroz]

*** Bug 47501 has been marked as a duplicate of this bug. ***

Comment 6

[Jean-Francois Ducarroz]

I see the crash also when the copy operation succeeded.

Comment 7

[Jean-Francois Ducarroz]

I found the problem: 

at the end of the function nsMsgLocalMailFolder::EndCopy, you do : 

srcFolder = do_QueryInterface(mCopyState->m_srcSupport, &rv); 
if (srcFolder) 
... 

The problem is that in my case, I don't have a source folder therefore the query interface will failed
and rv will contains an error. As we return an error, we will later thought that the copy failed and
therefore clear the request but the request has been already cleared by the completion runtine
because the copy didn't failed but correctly succeeded. 

the fix is to do: 

srcFolder = do_QueryInterface(mCopyState->m_srcSupport); 
if (srcFolder) 
... 

Comment 8

[Jon Granrose]

get it reviewed and check it in, a=granrose.

Comment 9

[Jean-Francois Ducarroz]

Fixed and checked in

Comment 10

[Alek Jeziorek]

No longer see this on Linux build 2000-08-04-08-M18 will verify after checking 
win and mac

Comment 11

[Alek Jeziorek]

no longer see this on any platoforms using build 2000-08-04-08-M18; verifying