Closed
Bug 475120
Opened 15 years ago
Closed 15 years ago
port bug 464154, bug 453840, bug 472431 to comm-central locale Makefiles
Categories
(MailNews Core :: Build Config, defect)
MailNews Core
Build Config
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.0b2
People
(Reporter: kairo, Assigned: kairo)
References
Details
Attachments
(1 file, 1 obsolete file)
21.18 KB,
patch
|
standard8
:
review+
|
Details | Diff | Splinter Review |
At least parts of the following patches should be ported to the comm-central locales/Makefile.in files: http://hg.mozilla.org/releases/mozilla-1.9.1/rev/25c62f20137fb05d42afda5178050e2303a14967 bug 464154: l10n-for-releases fixes, l10n-upload-% target. r=pike,ted http://hg.mozilla.org/releases/mozilla-1.9.1/rev/18aefb9b7345e73ac544965d4fe644eac38002e6 [OS/2] Bug 460247: move the OS/2 README.txt files out of the locale directories (mozilla-central part), r=ted, a191=beltzner http://hg.mozilla.org/releases/mozilla-1.9.1/rev/a28d67a980fe94e8919068e323990612254ffe21 bug 453840: remove MOZ_PKG_PRETTYNAMES special case in browser/locales/Makefile.in. r=tmielczarek. http://hg.mozilla.org/mozilla-central/rev/8fe5bc1ec5e943055b1948ed398eedb3b0301499 bug 472431, don't add install.rdf and chrome.manifest to installers and packages, as they're just for the language packs, r=bhearsum
Assignee | ||
Comment 1•15 years ago
|
||
Here's the patch for this - do we need someone from Calendar to review this as well?
Attachment #358522 -
Flags: review?(bugzilla)
Comment 2•15 years ago
|
||
Comment on attachment 358522 [details] [diff] [review] update L10n Makefiles -ifneq ($(OS_ARCH),OS2) $(SYSINSTALL) $(IFLAGS1) $^ $(FINAL_TARGET) -endif I don't understand this change. Bug 460247 was adding it so I don't see why you are removing it.
Assignee | ||
Comment 3•15 years ago
|
||
(In reply to comment #2) > (From update of attachment 358522 [details] [diff] [review]) > -ifneq ($(OS_ARCH),OS2) > $(SYSINSTALL) $(IFLAGS1) $^ $(FINAL_TARGET) > -endif > > I don't understand this change. Bug 460247 was adding it so I don't see why you > are removing it. Oops, right. Sometimes late-night build system work apparently produces errors. It's good we have reviews :)
Assignee | ||
Updated•15 years ago
|
No longer depends on: 460247
Summary: port bug 464154, bug 460247, bug 453840, bug 472431 to comm-central locale Makefiles → port bug 464154, bug 453840, bug 472431 to comm-central locale Makefiles
Assignee | ||
Comment 4•15 years ago
|
||
Here's the patch without those wrong OS/2 changes.
Attachment #358522 -
Attachment is obsolete: true
Attachment #358888 -
Flags: review?(bugzilla)
Attachment #358522 -
Flags: review?(bugzilla)
Comment 5•15 years ago
|
||
Comment on attachment 358888 [details] [diff] [review] update L10n Makefiles, v1.1 r=me (again by inspection, but a couple of quick tests on the l10n side as well).
Attachment #358888 -
Flags: review?(bugzilla) → review+
Assignee | ||
Comment 6•15 years ago
|
||
Pushed as http://hg.mozilla.org/comm-central/rev/efe8315bc045
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•