Closed
Bug 475127
Opened 16 years ago
Closed 16 years ago
TM: LirNameMap gets large over time and searching it with binary search is slow
Categories
(Core :: JavaScript Engine, enhancement, P3)
Tracking
()
RESOLVED
FIXED
People
(Reporter: gal, Assigned: gal)
References
Details
(Keywords: fixed1.9.1, Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file, 1 obsolete file)
|
634 bytes,
patch
|
shaver
:
review+
shaver
:
approval1.9.1+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•16 years ago
|
||
This is a debug-only issue.
Severity: normal → enhancement
Priority: -- → P3
FWIW, this means I can no longer dogfood Tracemonkey.
Would it help if we purged the map when we purged the JIT cache (at every GC)?
Also, hey, I bet we don't even use the name map if TRACEMONKEY=verbose isn't set, so we don't need to be putting stuff in it...
|
|
Assignee | |
Comment 6•16 years ago
|
||
Assignee: general → gal
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 7•16 years ago
|
||
Attachment #358971 -
Attachment is obsolete: true
Attachment #358972 -
Flags: review?(shaver)
Attachment #358972 -
Flags: review?(shaver)
Attachment #358972 -
Flags: review+
Attachment #358972 -
Flags: approval1.9.1+
Comment on attachment 358972 [details] [diff] [review] v2 r/a=shaver
|
|
Assignee | |
Comment 9•16 years ago
|
||
Fixed in TM. Confirmation would be nice. http://hg.mozilla.org/tracemonkey/rev/e47e6340503e
Whiteboard: fixed-in-tracemonkey
|
|
Assignee | |
Comment 10•16 years ago
|
||
This slows down jesse's fuzzing so a+ for 1.9.1 is advised.
Nice!
|
||
Comment 12•16 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/e47e6340503e
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
|
||
Comment 13•16 years ago
|
||
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/351225f2f61a
Flags: wanted1.9.1+
Keywords: fixed1.9.1
|
||
Updated•15 years ago
|
Flags: in-testsuite-
You need to log in
before you can comment on or make changes to this bug.
Description
•