Closed
Bug 475278
Opened 17 years ago
Closed 17 years ago
reminderCustomUnit* should support plural forms in calendar-event-dialog.properties
Categories
(Calendar :: General, defect)
Calendar
General
Tracking
(Not tracked)
RESOLVED
WORKSFORME
People
(Reporter: rimas, Assigned: hubert+bmo)
Details
Attachments
(2 files, 1 obsolete file)
|
33.75 KB,
image/png
|
Details | |
|
10.07 KB,
patch
|
hubert+bmo
:
review-
|
Details | Diff | Splinter Review |
Custom Reminder - screenshot (patch applied)
calendar-event-dialog.properties currently has these lines:
reminderCustomUnitMinute=minute
reminderCustomUnitMinutes=minutes
reminderCustomUnitHour=hour
reminderCustomUnitHours=hours
reminderCustomUnitDay=day
reminderCustomUnitDays=days
it would be great if these would support plural forms.
OTOH, I'm wondering why we are not using the same strings from calendar-alarms.properties. Is this duplication required in any locale?
|
Assignee | |
Updated•17 years ago
|
Assignee: nobody → hubert
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•17 years ago
|
||
Attachment #359618 -
Flags: review?(philipp)
|
|
Assignee | |
Comment 2•17 years ago
|
||
|
|
Assignee | |
Comment 3•17 years ago
|
||
I should change the name of "reminderCustomTitle" key.
Attachment #359618 -
Attachment is obsolete: true
Attachment #359625 -
Flags: review?(philipp)
Attachment #359618 -
Flags: review?(philipp)
|
|
Assignee | |
Comment 4•17 years ago
|
||
Comment on attachment 359625 [details] [diff] [review]
Patch 0.2
Few lines were removed by http://hg.mozilla.org/comm-central/rev/125c3a73ab46 (bug 353492) so this patch is out of date.
Attachment #359625 -
Flags: review?(philipp) → review-
|
|
Assignee | |
Comment 5•17 years ago
|
||
WFM - Mozilla/5.0 (X11; U; Linux i686; pl; rv:1.9.1b3pre) Gecko/20090206 Calendar/1.0pre
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•