475327 - [Linux] New Tab button is still right side of the Tab bar

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect, P2)

Description

[Hideo Oshima]

Attachment: Screnshot of Tab bar

Bug 457651 has been fixed but New Tab button is still right side of
the Tab bar with Linux build.

Please see the screenshot.

Comment 1

[ojab]

The same (New Tab button on left) on Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2a1pre) Gecko/20090125 Minefield/3.2a1pre

Comment 2

[Dão Gottwald [:dao]]

Looks like we're getting a flawed overflow event from the arrowscrollbox.

Comment 3

[Dave Garrett]

I only see this using the default theme. Other themes show with it at the end of the tab list.

Comment 4

[Ed Lee :Mardak]

I was playing around with the styles on os x and accidentally changed the margin-bottom of the tabs. This seems to have caused this same bug, so it's overflowing vertically and thinking it should show the right-aligned new tab button.

Comment 5

[Dão Gottwald [:dao]]

Attachment: patch

Yeah, we need to check the overflow direction.
I think it's also time to clean up the handling of these events a bit.

Comment 6

[Dão Gottwald [:dao]]

Comment on attachment 358879 [details] [diff] [review]
patch

>diff --git a/toolkit/content/widgets/scrollbox.xml b/toolkit/content/widgets/scrollbox.xml

>-      <handler event="underflow"><![CDATA[
>+      <handler event="underflow" phase="capturing"><![CDATA[

>-      <handler event="overflow"><![CDATA[
>+      <handler event="overflow" phase="capturing"><![CDATA[

Note that these handlers need to run before those in tabbrowser.xml, hence this change.

Comment 7

[Hideo Oshima]

(In reply to comment #5)
> Created an attachment (id=358879) [details]
> patch
> 
> Yeah, we need to check the overflow direction.
> I think it's also time to clean up the handling of these events a bit.

I tried the patch.
It looks good for me.
Thanks.

Comment 8

[Michael Kohler [:mkohler]]

Works for me in Ubuntu 8.10 with Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2a1pre) Gecko/20090129 Minefield/3.2a1pre ID:20090129020428 ...

The patch isn't implemented yet, is it?

Comment 9

[Dão Gottwald [:dao]]

No, it isn't.

Comment 10

[Michael Kohler [:mkohler]]

So that means that it is fixed without this patch? Or am I the only one?

Comment 11

[Dão Gottwald [:dao]]

To reproduce this bug, you need to use the default theme and open a window where the tab bar doesn't overflow immediately (that is, without restoring a session with lots of tabs).

Comment 12

[Michael Kohler [:mkohler]]

Oh, I'm sorry.

But it occurs also when I use a new profile and then use the normal one.

Comment 13

[Michael Kohler [:mkohler]]

You can download my build (just finished compiling) at http://mozilla.webdesign-portal.net .. Looks like the patch works!

Comment 14

[Michael Kohler [:mkohler]]

Sometimes it works for me without this patch.. But only sometimes and I couldn't figure out why it does that..

Comment 15

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 358879 [details] [diff] [review]
patch

(In reply to comment #6)
> Note that these handlers need to run before those in tabbrowser.xml, hence this
> change.

Why? r=me with that explained.

Comment 16

[Dão Gottwald [:dao]]

(In reply to comment #15)
> (From update of attachment 358879 [details] [diff] [review])
> (In reply to comment #6)
> > Note that these handlers need to run before those in tabbrowser.xml, hence this
> > change.
> 
> Why? r=me with that explained.

Because this.scrollBoxObject.ensureElementIsVisible(tabs.selectedItem); needs to run after the scroll buttons are shown, otherwise the selected tab won't be fully visible. This means that the underflow handler in scrollbox.xml doesn't need to change, but I figured it's better to make both cases consistent.

Comment 17

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/89fb0fa39e0b
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/97d4c788dee0

Comment 18

[Marcia Knous [:marcia]]

Verified on the 1.9.1 branch using Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b3pre) Gecko/20090213 Shiretoko/3.1b3pre.

Comment 19

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified fixed with Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2b3pre) Gecko/20091111 Namoroka/3.6b3pre ID:20091111033750