Closed Bug 475503 Opened 15 years ago Closed 15 years ago

mochitest for hide event when DOM node containing accessibles is removed from DOM

Categories

(Core :: Disability Access APIs, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: surkov, Assigned: surkov)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file, 1 obsolete file)

no hide event when DOM node containing accessibles is removed from DOM
it works actually, the problem was in mochitest
Summary: no hide event when DOM node containing accessibles is removed from DOM → mochitest for hide event when DOM node containing accessibles is removed from DOM
Attached patch patch (obsolete) — Splinter Review
Assignee: nobody → surkov.alexander
Status: NEW → ASSIGNED
Attachment #378858 - Flags: review?(marco.zehe)
Attachment #378858 - Flags: review?(david.bolter)
Blocks: a11ytestdev
Comment on attachment 378858 [details] [diff] [review]
patch

>+      /**
>+       * Change default target registered for the given event type for first
>+       * target from the array and inserts another targets from the array
>+       * after default target.
>+       */

I don't understand this.
Attached patch patch2Splinter Review
is it better?
Attachment #378858 - Attachment is obsolete: true
Attachment #378862 - Flags: review?(marco.zehe)
Attachment #378862 - Flags: review?(david.bolter)
Attachment #378858 - Flags: review?(marco.zehe)
Attachment #378858 - Flags: review?(david.bolter)
Comment on attachment 378862 [details] [diff] [review]
patch2

>+      /**
>+       * Change default target registered for the given event type on the first
>+       * node from the targets array. Inserts remaining nodes from the targets
>+       * array right after default target into event sequence array.
>+       */

Maybe something like:

Replace the default target currently registered for a given event type with the nodes in the targets array. The first node in the targets array specifies the default target to be replaced, the remaining nodes are what replaces it.
Ok I changed locally on the following:

> Replace the default target currently registered for a given event type with the
> nodes in the targets array.
Attachment #378862 - Flags: review?(marco.zehe) → review+
(In reply to comment #6)
> Ok I changed locally on the following:
> 
> > Replace the default target currently registered for a given event type with the
> > nodes in the targets array.

Sounds good.
Attachment #378862 - Flags: review?(david.bolter) → review+
Comment on attachment 378862 [details] [diff] [review]
patch2

r=me with the comment change.
checked in on mozilla 1.9.2, http://hg.mozilla.org/mozilla-central/rev/aeca3394b861
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: