475532 - ASSERTION: nsXPInstallManager not thread-safe: '_mOwningThread.GetThread() == PR_GetCurrentThread()', file /Users/dave/mozilla/source/trunk/mozilla/xpinstall/src/nsXPInstallManager.cpp

Status: RESOLVED FIXED

(Core Graveyard :: Installer: XPInstall Engine, defect)

Description

[Dave Townsend [:mossop]]

While it is never getting called on a non-main thread, the badcertlistener code is called through a proxy to the main thread, and creating that proxy requires the object to have threadsafe addref/release implementations.

Comment 1

[Dave Townsend [:mossop]]

Attachment: patch rev 1

Give it threadsafe implementations

Comment 2

[Benjamin Smedberg]

Comment on attachment 359046 [details] [diff] [review]
patch rev 1

Please add an assertion to ~nsXPInstallManager that it is always being destroyed on the main thread (last release).

Comment 3

[Dave Townsend [:mossop]]

Pushed: http://hg.mozilla.org/mozilla-central/rev/0d50fb80f608

Comment 4

[Dave Townsend [:mossop]]

Attachment: patch checked in

I'd like to land this on the 1.9.1 branch. I don't expect it likely we'd see any problems fixed by this, though it certainly wouldn't hurt, but I would like to land bug 474763 on the branch

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 361519 [details] [diff] [review]
patch checked in

a191=beltzner

Comment 6

[Dave Townsend [:mossop]]

Landed on branch http://hg.mozilla.org/releases/mozilla-1.9.1/rev/f1deb194fcbb

Comment 7

[Samuel Sidler (old account; do not CC)]

Comment on attachment 361519 [details] [diff] [review]
patch checked in

Approving both of these for 1.9.0.10. a=ss for release-drivers.

Comment 8

[Dave Townsend [:mossop]]

Landed on 1.9.0.x branch:

Checking in xpinstall/src/nsXPInstallManager.cpp;
/cvsroot/mozilla/xpinstall/src/nsXPInstallManager.cpp,v  <--  nsXPInstallManager.cpp
new revision: 1.168; previous revision: 1.167
done