475599 - Create the backup files in calendar-data folder instead of the backupData folder

Status: RESOLVED FIXED

(Calendar :: Provider: ICS/WebDAV, enhancement)

Description

[Stefan Sitter [:ssitter]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090127 Calendar/1.0pre (BuildID: 20090127085840).

Currently the ics provider creates backups of the online calendars in folder "<profile>/backupData".

To keep the calendar data in one place I suggest that the backups are created in the "<profile>/calendar-data" (or "<profile>/calendar-data/backup") folder that already stores the database files.

Comment 1

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Daniel, can you look into this? Seems like a simple step to do. I'd say we just change the location and offer no migration. Might be confusing at first, but I doubt its worth adding migration code.

Comment 2

[Daniel Boelzle [:dbo]]

Attachment: proposed patch - v1

Looking at the code this looks indeed simple; haven't tested though...

Comment 3

[Stefan Sitter [:ssitter]]

Comment on attachment 359243 [details] [diff] [review]
proposed patch - v1

r=ssitter if you shorten the subfolder name from "backupData" to just "backup".

Comment 4

[Daniel Boelzle [:dbo]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/a00a6313665f>

-> FIXED

Comment 5

[Gregg Reed]

Would it be possible to have this backup for CalDAV calendars also?  If so, do you need a new bug report?
Thanks.

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

I don't think the calendars should have a backup function in core code. Please check out the "Automatic Export" extension: https://addons.mozilla.org/en-US/sunbird/addon/3740

Comment 7

[Simon Paquet [:sipaq]]

Martin, why did you add the relnote keyword here? What is relnote worthy?
I'd also need a text for the relnote, because I don't know what the issue here is.

Comment 8

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".