Closed Bug 475599 Opened 12 years ago Closed 12 years ago

Create the backup files in calendar-data folder instead of the backupData folder

Categories

(Calendar :: Provider: ICS/WebDAV, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ssitter, Assigned: dbo)

Details

Attachments

(1 file)

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090127 Calendar/1.0pre (BuildID: 20090127085840).

Currently the ics provider creates backups of the online calendars in folder "<profile>/backupData".

To keep the calendar data in one place I suggest that the backups are created in the "<profile>/calendar-data" (or "<profile>/calendar-data/backup") folder that already stores the database files.
Daniel, can you look into this? Seems like a simple step to do. I'd say we just change the location and offer no migration. Might be confusing at first, but I doubt its worth adding migration code.
Looking at the code this looks indeed simple; haven't tested though...
Attachment #359243 - Flags: review?(ssitter)
Assignee: nobody → daniel.boelzle
Status: NEW → ASSIGNED
OS: Windows XP → All
Hardware: x86 → All
Attachment #359243 - Flags: review?(ssitter) → review+
Comment on attachment 359243 [details] [diff] [review]
proposed patch - v1

r=ssitter if you shorten the subfolder name from "backupData" to just "backup".
Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/a00a6313665f>

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.0
Would it be possible to have this backup for CalDAV calendars also?  If so, do you need a new bug report?
Thanks.
I don't think the calendars should have a backup function in core code. Please check out the "Automatic Export" extension: https://addons.mozilla.org/en-US/sunbird/addon/3740
Martin, why did you add the relnote keyword here? What is relnote worthy?
I'd also need a text for the relnote, because I don't know what the issue here is.
These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".
Target Milestone: 1.0 → 1.0b1
You need to log in before you can comment on or make changes to this bug.