475798 - Library: Alt+E only focuses the More button, doesn't trigger it

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Simon Bünzli]

... due to bug 438306.

This regressed on Windows due to bug 403151 (probably never worked on the other platforms).

Comment 1

[Simon Bünzli]

Attachment: obvious fix: remove the offending lines

NB: The code to correctly update the accesskey on the <button type="image"> was removed while the accesskey was added.

Comment 2

[Marco Bonardo [:mak]]

Comment on attachment 359352 [details] [diff] [review]
obvious fix: remove the offending lines

thanks!

Comment 3

[Simon Bünzli]

Comment on attachment 359352 [details] [diff] [review]
obvious fix: remove the offending lines

Drivers: This trivial patch only removes dead/obstructing code that shouldn't be there in the first place.

Comment 4

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/76540a65adc0

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified with Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2a1pre) Gecko/20090131 Minefield/3.2a1pre

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 359352 [details] [diff] [review]
obvious fix: remove the offending lines

a191=beltzner

Comment 7

[Marco Bonardo [:mak]]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/89dd6cbdd022

Comment 8

[Aakash Desai [:aakashd]]

verified FIXED on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b4pre) Gecko/20090331 Shiretoko/3.5b4pre ID:20090331041754

Comment 9

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv