475803 - cal.fromRFC3339 matches fails to set timezone correctly

Status: RESOLVED FIXED

(Calendar :: Provider: GData, defect)

Description

[Patrick Cloke [:clokep]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b2) Gecko/20081201 Firefox/3.1b2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b3pre) Gecko/20081204 Lightning/1.0pre Thunderbird/3.0b1

If a lowercase 'z' is given for the timezone information of the UTC string it matches the regular expression but then will not set the timezone as UTC.

Reproducible: Always

Steps to Reproduce:
1. Feed an RFC 3339 time to cal.fromRFC3339 with a timezone of 'z'
2. Example: "2050-11-14t13:30:53z"

Actual Results:  
The timezone gets parsed as calendarDefaultTimezone instead of UTC

Expected Results:  
The timezone should get parsed as UTC

Comment 1

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

afaik a lowercase z is not allowed in the spec?

Comment 2

[Patrick Cloke [:clokep]]

Attachment: Fixes the described error

Comment 3

[Patrick Cloke [:clokep]]

Attachment: Slight fix to the previous patch

Comment 4

[Patrick Cloke [:clokep]]

http://www.ietf.org/rfc/rfc3339.txt

On page "7" (section: "5.6. Internet Date/Time Format"):

"NOTE: Per [ABNF] and ISO8601, the "T" and "Z" characters in this
syntax may alternatively be lower case "t" or "z" respectively.

This date/time format may be used in some environments or contexts
that distinguish between the upper- and lower-case letters 'A'-'Z'
and 'a'-'z' (e.g. XML).  Specifications that use this format in
such environments MAY further limit the date/time syntax so that
the letters 'T' and 'Z' used in the date/time syntax must always
be upper case.  Applications that generate this format SHOULD use
upper case letters."

Although as I'm re-reading this again that may be referring to only ISO 8601, in which case this bug is incorrect. Its kind of ambigious whether its referring to ISO 8601 or 'THIS' profile of ISO 8601 (meaning RFC 3339).

Comment 5

[Patrick Cloke [:clokep]]

Also, the regex checks for "Tt" and "Zz", if "z" can match in the regex the rest of the script needs to be able to handle it. So either the regex needs to be set to be "T" and "Z" or the patch I proposed needs to be added (which simply checks for "Z" or "z" when setting the timezone).

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 359365 [details] [diff] [review]
Slight fix to the previous patch

Next time, please request review.

r=philipp

Comment 7

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/dcb38165108d

Comment 8

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".