475830 - Downloads should end up in My Documents/Downloads for winxp

Status: VERIFIED FIXED

(Toolkit :: Downloads API, defect, P2)

Description

[Shawn Wilsher :sdwilsh]

Downloads should end up in My Documents/Downloads and not in Desktop/Downloads for windows XP

Comment 1

[Shawn Wilsher :sdwilsh]

There's a bit of an issue with making this change in xpcom/io/SpecialSystemDirectory.cpp as originally discussed with gavin.  We need to localize the downloads folder name, and I'm not 100% sure we can get a string bundle in that code (and then, we'd be breaking string freeze for 3.1).

We can fix this strictly in the download manager code, however.  Awaiting input on how gavin wants this done.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

You can just avoid moving the folder creation code for now, I guess.

Comment 3

[Shawn Wilsher :sdwilsh]

Attachment: v1.0

This only makes changes in nsDownloadManager.cpp.  I figure it doesn't make sense to have the xpcom code fall back to My Documents as the download folder for XP/2k, and it could break any add-ons that rely on it now.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #3)
> I figure it doesn't make sense to have the xpcom code fall back to My Documents
> as the download folder for XP/2k, and it could break any add-ons that rely on
> it now.

Yeah, makes sense.

Comment 5

[Shawn Wilsher :sdwilsh]

Comment on attachment 359414 [details] [diff] [review]
v1.0

Asking for approval if we don't get blocking+

Comment 6

[Shawn Wilsher :sdwilsh]

http://hg.mozilla.org/mozilla-central/rev/8e03c785ee07

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Shawn, how can I verify this change? I suspect that no-one should notice something when saving a file in a fresh profile. Currently we already use the "download" folder under the user profile. So do we had to adjust it because of bug 384068?

Comment 8

[pal-moz]

"Downloads" folder should not be created if/when download is "Desktop" or other folder ?
see https://bugzilla.mozilla.org/show_bug.cgi?id=474718#c4

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Thanks for the hint. I can verify the fix with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090130 Minefield/3.2a1pre

Comment 10

[Shawn Wilsher :sdwilsh]

Comment on attachment 359414 [details] [diff] [review]
v1.0

Don't need approval anymore

Comment 11

[Shawn Wilsher :sdwilsh]

Branch didn't have the stuff that was landed for bug 429827, so the patch didn't cleanly apply.  Fixed it up and pushed:
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/f57bc5673b90

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090201 Shiretoko/3.1b3pre

While testing this patch I've noticed that saving a link to disk leaves the downloaded file with the .part extension on disk. I'll file a new bug on that.