If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

|make test| hangs on test_auth_manager and test_resource

RESOLVED FIXED

Status

Cloud Services
General
RESOLVED FIXED
9 years ago
8 years ago

People

(Reporter: myk, Assigned: myk)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
Created attachment 359426 [details] [diff] [review]
patch that fixes problems

|make test| hangs running test_auth_manager, and if you remove that test, it later hangs on test_resource.  Both hangs are due to those tests being asynchronous and hitting exceptions that cause them never to complete.

Mostly the exception is that Resource.lastRequest doesn't have any properties.  That's because revision 1cb3eac16b1e <http://hg.mozilla.org/labs/weave/rev/1cb3eac16b1e> from December mostly removed that property.

Revision 671ee7bb183a <http://hg.mozilla.org/labs/weave/rev/671ee7bb183a> from yesterday finishes removing it but replaces it with Resource.lastChannel, which is an nsIHTTPChannel and so provides the information that the tests want in its responseStatus and responseStatusText properties.

test_resource also throws because its third test still passes an authenticator to the Resource constructor, even though the authenticator parameter was removed from the Resource constructor in revision bfc289861adc <http://hg.mozilla.org/labs/weave/rev/bfc289861adc>, so the request doesn't get authenticated and fails.

As an aside, test_resource fails even after those problems are fixed because its fourth test expects the response text for a file that doesn't exist to be "File not found", whereas that's actually the content of the response.  The response text is "Not Found".

Here's a patch that replaces references to |lastRequest| with references to |lastChannel|, sets a Resource's authenticator via its authenticator property when needed, and checks for the appropriate response text when getting a file that doesn't exist.
(Assignee)

Comment 1

9 years ago
Fixed by changeset 4ede5a336cea <http://hg.mozilla.org/labs/weave/rev/4ede5a336cea>.
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED

Updated

8 years ago
Component: Weave → General
Product: Mozilla Labs → Weave
Target Milestone: -- → ---

Updated

8 years ago
Component: Weave → General
Product: Mozilla Labs → Weave
Target Milestone: -- → ---
QA Contact: weave → general
You need to log in before you can comment on or make changes to this bug.