Prevent unnecessary box-shadow repaints by implementing nsDisplayBoxShadow::OptimizeVisibility

RESOLVED FIXED

Status

()

Core
Layout
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Michael Ventnor, Assigned: Michael Ventnor)

Tracking

({fixed1.9.1, perf})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
Created attachment 359456 [details] [diff] [review]
Patch

This function allows you to specify whether a display list item is really necessary or not. If we could overload this within nsDisplayBoxShadow, this could really speed things up for box-shadow on stuff like <video> and windowless plugins by preventing unnecessary repainting of box-shadow underneath the actual frame.
Attachment #359456 - Flags: superreview?(roc)
Attachment #359456 - Flags: review?(roc)
Attachment #359456 - Flags: superreview?(roc)
Attachment #359456 - Flags: superreview+
Attachment #359456 - Flags: review?(roc)
Attachment #359456 - Flags: review+
(Assignee)

Comment 1

8 years ago
Just to leave myself a note here for future debugging hair-ripping, if we ever implement the 'inset' feature in the box-shadow editor's draft, this code will need to change so it only happens for outset shadows.
Keywords: checkin-needed
Whiteboard: [needs landing]
Pushed http://hg.mozilla.org/mozilla-central/rev/3777df92cc24
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [needs landing] → [needs 191 landing]
Comment on attachment 359456 [details] [diff] [review]
Patch

Simple patch that will help perf with this new feature
Attachment #359456 - Flags: approval1.9.1+
Keywords: checkin-needed
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/9eae7dae877e
Keywords: checkin-needed → fixed1.9.1
Whiteboard: [needs 191 landing]
You need to log in before you can comment on or make changes to this bug.