475902 - buildbot's "Stop build" doesn't work for unit test, aborts current test only

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P5)

Description

[Nick Thomas [:nthomas] (UTC+12)]

If a builder is busy doing (say) reftest and you go Stop build then it moves on to crashtest, kill it again to get mochitest etc. Not the end of the world but a bit of a pain.

Comment 1

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

Annoying but not the end of the world. Also, we split out unittests and run each suite separately, the need for this may go away?

Triaging to Future for now.

Comment 2

[Chris Cooper [:coop] (he/him)]

Is the problem that we don't have haltOnFailure=True for these steps?

Comment 3

[Aki Sasaki (not active)]

Yeah. But I agree with comment #1; once we split all unit test suites out to their own builder, we can haltOnFailure with no unwanted consequences.  Otherwise a failure in an early test will prevent us from running the rest of the tests.

Comment 4

[Chris AtLee [:catlee]]

I think in general, we don't want haltOnFailure set for tests.  It means that a build that fails in one suite won't run the rest in places where we're running more than one suite, like the 'everythingelse' build.

The proper way to fix this is in buildbot, where if 'Stop Build' is pressed, it prevents subsequent steps from being run instead of just sending SIGINT to the current step.

Comment 5

[Chris Cooper [:coop] (he/him)]

Mass move of bugs from Release Engineering:Future -> Release Engineering. See http://coop.deadsquid.com/2010/02/kiss-the-future-goodbye/ for more details.

Comment 6

[Chris AtLee [:catlee]]

This will get fixed when we roll out buildbot 0.8.0

Comment 7

[Chris AtLee [:catlee]]

Now that the primary build and test masters are on 0.8.0, I'm going to call this fixed.