buildbot's "Stop build" doesn't work for unit test, aborts current test only

RESOLVED FIXED

Status

Release Engineering
General
P5
minor
RESOLVED FIXED
9 years ago
4 years ago

People

(Reporter: nthomas, Assigned: catlee)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

9 years ago
If a builder is busy doing (say) reftest and you go Stop build then it moves on to crashtest, kill it again to get mochitest etc. Not the end of the world but a bit of a pain.
Annoying but not the end of the world. Also, we split out unittests and run each suite separately, the need for this may go away?

Triaging to Future for now.
Component: Release Engineering → Release Engineering: Future

Comment 2

8 years ago
Is the problem that we don't have haltOnFailure=True for these steps?

Comment 3

8 years ago
Yeah. But I agree with comment #1; once we split all unit test suites out to their own builder, we can haltOnFailure with no unwanted consequences.  Otherwise a failure in an early test will prevent us from running the rest of the tests.
Assignee: nobody → lsblakk
(Assignee)

Comment 4

8 years ago
I think in general, we don't want haltOnFailure set for tests.  It means that a build that fails in one suite won't run the rest in places where we're running more than one suite, like the 'everythingelse' build.

The proper way to fix this is in buildbot, where if 'Stop Build' is pressed, it prevents subsequent steps from being run instead of just sending SIGINT to the current step.

Comment 5

8 years ago
Mass move of bugs from Release Engineering:Future -> Release Engineering. See http://coop.deadsquid.com/2010/02/kiss-the-future-goodbye/ for more details.
Component: Release Engineering: Future → Release Engineering
Priority: -- → P3
(Assignee)

Comment 6

8 years ago
This will get fixed when we roll out buildbot 0.8.0
Depends on: 508672
Assignee: lsblakk → nobody
Priority: P3 → P5
(Assignee)

Updated

8 years ago
Assignee: nobody → catlee
(Assignee)

Comment 7

7 years ago
Now that the primary build and test masters are on 0.8.0, I'm going to call this fixed.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.