476097 - "ASSERTION: killing mutation events" with <input type="file">

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Jesse Ruderman]

Attachment: testcase

###!!! ASSERTION: killing mutation events: 'nsContentUtils::IsSafeToRunScript()', file ../../../dist/include/content/nsContentUtils.h, line 1549

Comment 1

[Boris Zbarsky [:bzbarsky]]

Smaug, I thought we didn't fire mutation events on native anon content...

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Some of the assertions come from nsFileControlFrame::CreateAnonymousContent
where we set attributes using .SetXXX methods before marking elements to be
native anonymous.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

Mark created elements native anon already before returning from 
CreateAnonymousContent. 
Also change SetNativeAnonymous() so that content objects which are
marked to be native anon, are marked to be in native anon subtree even
before they are bound to anywhere.
I went through other CreateAnonymousContent implementations and they looked
ok.

I could probably remove IsRootOfNativeAnonymousSubtree() check from
::BindToTree, but I'd like to keep it there for now.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

And nsContentUtils::HasMutationListeners could be optimized so that it would
return false in this, even if the elements aren't in native anon.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Attachment: check window's mutation listener only if node is in document

This fixes the assertion too. I'd like to take both patches.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 359744 [details] [diff] [review]
patch

This doesn't need an IID rev, does it?

And it might be good to add comments in nsFileControlFrame explaining that the anonymous thing is to prevent the notifications about the attr set from seeing non-anonymous nodes.

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

I wasn't sure about the IID. I decided to update it so that whoever uses nsIContent really gets to updated inline method.

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

http://hg.mozilla.org/mozilla-central/rev/1ef539e37fba