Closed Bug 476106 Opened 13 years ago Closed 13 years ago

Unable to get directory path for directories immediately under some symlinks

Categories

(Toolkit :: NSIS Installer, defect, P2)

1.9.1 Branch
x86
Windows Vista
defect

Tracking

()

RESOLVED FIXED
mozilla1.9.1b3

People

(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)

References

Details

(Keywords: fixed1.9.1)

Attachments

(2 files)

This is a followup to bug 456895. The installer's GetLongPath macro has difficulty getting paths for files and directories under some symlinks. Specifically, if the app directory is under a Vista provided symlink as described in bug 456895 comment #21 the GetLongPath macro will fail. I have a fix for this and will submit a patch hopefully tomorrow.

For this fix to make any difference bug 456895 will need to be fixed so adding dependency.
Assignee: nobody → robert.bugzilla
Attached patch patch rev1Splinter Review
Hey Jim, in some circumstances the user may not have permissions for directory traversal. This patch replaces GetFullPathName $INSTDIR "$EXEDIR\.." with the GetParent macro to fix this and cleans up the GetLongPath macro since it now removes the trailing slash at the end.
Attachment #359827 - Flags: review?(jmathies)
Priority: -- → P2
Drivers, I'm nominating this to block since this could affect international Vista users in the same way as bug 456895 can and there is a very safe patch attached to this bug.
Flags: blocking1.9.1?
Flags: blocking1.9.1? → blocking1.9.1+
Comment on attachment 359827 [details] [diff] [review]
patch rev1

wfm!
Attachment #359827 - Flags: review?(jmathies) → review+
Pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/48179fdcfd3d
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
filed w/ patches Bug 477009 (Sunbird), Bug 477010 (SeaMonkey), and Bug 477011 (Thunderbird) for the one liner changes to uninstaller.nsi
Target Milestone: --- → mozilla1.9.1b3
You need to log in before you can comment on or make changes to this bug.