476106 - Unable to get directory path for directories immediately under some symlinks

Status: RESOLVED FIXED

(Toolkit :: NSIS Installer, defect, P2)

Description

[Robert Strong (they/them - no direct email)]

This is a followup to bug 456895. The installer's GetLongPath macro has difficulty getting paths for files and directories under some symlinks. Specifically, if the app directory is under a Vista provided symlink as described in bug 456895 comment #21 the GetLongPath macro will fail. I have a fix for this and will submit a patch hopefully tomorrow.

For this fix to make any difference bug 456895 will need to be fixed so adding dependency.

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

Hey Jim, in some circumstances the user may not have permissions for directory traversal. This patch replaces GetFullPathName $INSTDIR "$EXEDIR\.." with the GetParent macro to fix this and cleans up the GetLongPath macro since it now removes the trailing slash at the end.

Comment 2

[Robert Strong (they/them - no direct email)]

Drivers, I'm nominating this to block since this could affect international Vista users in the same way as bug 456895 can and there is a very safe patch attached to this bug.

Comment 3

[Jim Mathies [:jimm]]

Comment on attachment 359827 [details] [diff] [review]
patch rev1

wfm!

Comment 4

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/48179fdcfd3d

Comment 5

[Robert Strong (they/them - no direct email)]

Attachment: followup to do the same thing in uninstaller.nsi

Comment 6

[Robert Strong (they/them - no direct email)]

filed w/ patches Bug 477009 (Sunbird), Bug 477010 (SeaMonkey), and Bug 477011 (Thunderbird) for the one liner changes to uninstaller.nsi

Comment 7

[Robert Strong (they/them - no direct email)]

Pushed to a fully green mozilla-1.9.1!
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/89a76e45e282