476157 - NSS_3_11_10_WITH_CKBI_1_67_RTM for 1.8 branch

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[Alexander Sack]

1.8 branch wants to pick up the NSS fix for bug 471715.

NSS_3_11_10_WITH_CKBI_1_67_RTM is what we might want for that.

Note that current NSS on 1.8 branch is NSS_3_11_9_RTM.

Comment 1

[Alexander Sack]

Attachment: update client.mk NSS tag

currently using ffox 2 with the updated NSS .. seems to work for the use cases tested so far.

Comment 2

[Alexander Sack]

Samuel, what testing do you think is needed besides some insight on the changes done from 3.11.9 and .10 before we could consider to land this on branch?

Comment 3

[Samuel Sidler (old account; do not CC)]

Really, I'd just like a list of changes and for someone from the NSS tag to comment on the testing that's already been done.

Upping NSS on the 1.8.1 branch means our QA team needs to do some extra testing after it lands to ensure that it doesn't break anything in Thunderbird (since that's all MoCo is still shipping). Normally, things have been caught when testing Firefox, but since we aren't doing that anymore, I'm afraid we might miss something. If you (or any of the Linux distros) are putting it in your release, that might be enough testing, but Al should comment here. Al?

Comment 4

[Al Billings [:abillings - ex-MoCo]]

I don't have enough of a history with NSS to know what problems it has caused in the past or how it interacts with Thunderbird. My fear would be that it would destabilize Thunderbird (and potentially work by others in 1.8.1). What are the real risks with this change? What has happened when we've changed this before?

Comment 5

[Alexander Sack]

ok, seems like this has to wait for 1.8.1.22 as this needs some documentation (NSS changes) baking and QA for tbird and other 1.8 apps.

Comment 6

[Daniel Veditz [:dveditz]]

Blocking, but we do need to know what the diff is between 3.11.9 and 3.11.10 so it can be verified

Comment 8

[Kai Engert [:KaiE:]]

I don't have a list of high level changes between 3.11.9 and 3.11.10 and I'm afraid other people might not have either.

The 3.11.x branch is a highly stable branch that only receives handpicked bug fixes. It received the usual NSS testing of automated testsuite runs.

This update is also required in order to fix bug 478755.

Comment 9

[Kai Engert [:KaiE:]]

On the 3.11.9 release page I found the approximate release date.
Here is a bonsai query that lists all the changes to NSS in cvs after that date:

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=NSS_3_11_BRANCH&branchtype=match&dir=mozilla%2Fsecurity%2Fnss+mozilla%2Fsecurity%2Fcoreconf+mozilla%2Fsecurity%2Fdbm+mozilla%2Fdbm&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2008-01-31&maxdate=&cvsroot=%2Fcvsroot

Comment 10

[Samuel Sidler (old account; do not CC)]

Comment on attachment 359745 [details] [diff] [review]
update client.mk NSS tag

I looked through the changes and feel more comfortable with approving this.

Alexander: Can you make sure this gets landed by Friday?

Comment 11

[Samuel Sidler (old account; do not CC)]

I'm giving this to Alexander since he made the patch in this bug and ultimately needs to land it.

Comment 12

[Daniel Veditz [:dveditz]]

Fix checked in on the 1.8 branch