Beep when closing prefwindow with cmd+w in apps without own close key defined

RESOLVED FIXED in mozilla1.9.2a1

Status

()

RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: stefanh, Assigned: stefanh)

Tracking

({fixed1.9.1})

Trunk
mozilla1.9.2a1
x86
Mac OS X
fixed1.9.1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
(Same as bug 473444, forgot about the close key)

STR:

1) Launch Calendar or Seamonkey
2) Open preferences
3) Hit Cmd+W

Expected result: Prefwindow closes silently
Actual results: Prefwindow closes with a beep

This affects apps that doesn't have a second close key defined (either in a menu or in preferences.xul). Actually, it shouldn't be necessary to have a <key/> in preferences.xul (like thunderbird have), since we have a keypress handler for this in preferences.xml...
(Assignee)

Comment 1

10 years ago
Created attachment 359846 [details] [diff] [review]
use stopPropagation and preventDefault on the handler

Last keypress handler in preferences.xml...
Attachment #359846 - Flags: review?
(Assignee)

Updated

10 years ago
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.9.2a1
(Assignee)

Updated

10 years ago
Attachment #359846 - Flags: review? → review?(gavin.sharp)
Attachment #359846 - Flags: review?(gavin.sharp) → review+
(Assignee)

Comment 2

10 years ago
http://hg.mozilla.org/mozilla-central/rev/6076fd1df050
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
(Assignee)

Updated

10 years ago
Blocks: 476271
(Assignee)

Comment 3

10 years ago
Comment on attachment 359846 [details] [diff] [review]
use stopPropagation and preventDefault on the handler

This fixes a quite annoying mac-specific problem that hits consumers of the preference widget. Should be safe.
Attachment #359846 - Flags: approval1.9.1?
Comment on attachment 359846 [details] [diff] [review]
use stopPropagation and preventDefault on the handler

a191=beltzner
Attachment #359846 - Flags: approval1.9.1? → approval1.9.1+
You need to log in before you can comment on or make changes to this bug.