Closed Bug 476230 Opened 11 years ago Closed 11 years ago

remove all MoreFilesX usage

Categories

(Core :: XPCOM, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: jaas, Assigned: jaas)

References

Details

Attachments

(1 file)

This bug is specifically about removing all MoreFilesX usage from the tree and removing the MoreFilesX component. This is part of bug 456662.
Attached patch fix v1.0Splinter Review
Attachment #359848 - Flags: review?(smichaud)
Attachment #359848 - Flags: review?(smichaud) → review+
Comment on attachment 359848 [details] [diff] [review]
fix v1.0

Aside from one minor mistake, this looks fine to me.

In nsLocalFile::GetFileCreator(), this:

+  id creatorNum = (NSNumber*)[dict objectForKey:NSFileHFSCreatorCode];

should really be this:

+  NSNumber* creatorNum = (NSNumber*)[dict objectForKey:NSFileHFSCreatorCode];

I also have one observation.  It's not an objection -- I just want to
note it for future reference.  (And I somehow missed it when reviewing
this patch's predecessor at bug 456662.)

nsLocalFile::InitWithFSSpec() and nsLocalFile::GetFSSpec()
(apparently) originally fell back to using the parent directory (or
trying to use it) on an error.  I'm not sure this ever made much sense
... but in any case you've gotten rid of it.

I compiled and tested this patch ... but I'm not entirely sure how it
should be tested.  I just ran the browser and opened a local file.
Everything worked fine.
Attachment #359848 - Flags: superreview?(doug.turner)
Attachment #359848 - Flags: superreview?(doug.turner) → superreview+
pushed to mozilla-central, forgot to make the change Steven suggested, will follow up

http://hg.mozilla.org/mozilla-central/rev/85e381233997
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Depends on: 478549
Target Milestone: --- → mozilla1.9.2a1
This should probably be backed out right away -- it appears to have caused bug 478549.
Depends on: 464362
You need to log in before you can comment on or make changes to this bug.