Closed
Bug 476346
Opened 16 years ago
Closed 16 years ago
RTL Tree lines are rendered incorrectly
Categories
(Core :: XUL, defect)
Core
XUL
Tracking
()
RESOLVED
FIXED
mozilla1.9.2a1
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
(Keywords: fixed1.9.1, rtl)
Attachments
(1 file)
|
1.01 KB,
patch
|
roc
:
review+
roc
:
superreview+
dbaron
:
approval1.9.1+
|
Details | Diff | Splinter Review |
Followup from bug 140759: RTL XUL tree lines are rendered incorrectly. The reason is that the x "from" coordinate is incorrectly calculated to be on the left side of the tree. This causes the vertical lines to appear at the left side, and the horizontal ones appear all the way across the cell width to reach the right side (the starting point of the text).
The fix is pretty simple, as attached. To see this, DOM Inspector trees are an ideal example.
Attachment #359987 -
Flags: superreview?(roc)
Attachment #359987 -
Flags: review?(roc)
Attachment #359987 -
Flags: superreview?(roc)
Attachment #359987 -
Flags: superreview+
Attachment #359987 -
Flags: review?(roc)
Attachment #359987 -
Flags: review+
|
Assignee | |
Comment 1•16 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
|
|
Assignee | |
Comment 2•16 years ago
|
||
Comment on attachment 359987 [details] [diff] [review]
Patch (v1)
We would definitely want this for the branch together with the patch from bug 140759.
Attachment #359987 -
Flags: approval1.9.1?
Comment on attachment 359987 [details] [diff] [review]
Patch (v1)
a1.9.1=dbaron
Attachment #359987 -
Flags: approval1.9.1? → approval1.9.1+
|
|
Assignee | |
Comment 4•16 years ago
|
||
Keywords: fixed1.9.1
You need to log in
before you can comment on or make changes to this bug.
Description
•