476404 - [SeaMonkey] New a11y test_relations.xul fails: "... not a target of relation of 'embeds' type ..."

Status: VERIFIED FIXED

(Core :: Disability Access APIs, defect)

Description

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.2a1pre) Gecko/20090129 SeaMonkey/2.0a3pre] (experimental/_m-c_, home, optim default) (W2Ksp4)
(http://hg.mozilla.org/mozilla-central/rev/01c42e286b4c
 +http://hg.mozilla.org/comm-central/rev/dcb38165108d)
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.2a1pre) Gecko/20090201 SeaMonkey/2.0a3pre] (experimental/_m-c_, home, optim default) (W2Ksp4)
(http://hg.mozilla.org/mozilla-central/rev/3d2cbfcf9217
 +http://hg.mozilla.org/comm-central/rev/a62cac409cf7)

{
...
1100 ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/a11y/accessible/test_relations.html | [xpconnect wrapped (nsISupports, nsIAccessible, nsIAccessibleDocument, nsIAccessNode)] is not a target of relation of 'embeds' type for [xpconnect wrapped (nsISupports, nsIAccessible, nsIAccessibleDocument, nsIAccessNode)]. - got null, expected [xpconnect wrapped (nsISupports, nsIAccessible, nsIAccessibleDocument, nsIAccessNode)]
...
1121 ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/a11y/accessible/test_relations.xul | [xpconnect wrapped (nsISupports, nsIAccessible, nsIAccessibleDocument, nsIAccessNode)] is not a target of relation of 'embeds' type for [xpconnect wrapped (nsISupports, nsIAccessible, nsIAccessibleDocument, nsIAccessNode)]. - got null, expected [xpconnect wrapped (nsISupports, nsIAccessible, nsIAccessibleDocument, nsIAccessNode)]
...
}

Comment 1

[alexander :surkov (:asurkov)]

Ok, some investigations. The problem is root accessible (seamonkey window) doesn't expose EMBEDS relation and it may be a problem for screen readers.

Code lines:
1) get docshell tree item and get content tree item http://mxr.mozilla.org/mozilla-central/source/accessible/src/base/nsRootAccessible.cpp#1041
2) get accessible of content tree item
2.1) get DOM node for content tree item http://mxr.mozilla.org/mozilla-central/source/accessible/src/base/nsAccessNode.cpp#692
2.2) get pres shell for DOM node - http://mxr.mozilla.org/mozilla-central/source/accessible/src/base/nsAccessibilityService.cpp#1153

Obtained pres shell is null so we don't create accessible for content tree item.

Comment 2

[alexander :surkov (:asurkov)]

Attachment: patch

Neil's catch.

Comment 3

[alexander :surkov (:asurkov)]

Comment on attachment 362718 [details] [diff] [review]
patch

Marco, could you test AT who rely on embeds relation of root accessible?

Comment 4

[[e-mail]]

Comment on attachment 362718 [details] [diff] [review]
patch

This makes embed show up in DOM Inspector.

Comment 5

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 362718 [details] [diff] [review]
patch

Patch looks safe. If Marco says it fixes the bug r=me :)

Comment 6

[alexander :surkov (:asurkov)]

Marco, friendly ping.

Comment 7

[Marco Zehe (:MarcoZ)]

Comment on attachment 362718 [details] [diff] [review]
patch

>+    // Hidden documents don't have accessibles (like seamonekey's sidebar),

Nit: One e too much in "SeaMonkey's".

>+    // they are no of interest for a11y.

Nit: "They are of no interest...", swap "of" and "no".

I tested with all Windows screen readers, and they all pass.

Comment 8

[Marco Zehe (:MarcoZ)]

Comment on attachment 362718 [details] [diff] [review]
patch

Needed for SeaMonkey 2.

Comment 9

[alexander :surkov (:asurkov)]

Attachment: patch2

with Marco's comments

Comment 10

[alexander :surkov (:asurkov)]

http://hg.mozilla.org/mozilla-central/rev/ef19ac0459fd

Comment 11

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.2a1pre) Gecko/20090228 SeaMonkey/2.0b1pre] (experimental/_m-c_, home, optim default) (W2Ksp4)
(http://hg.mozilla.org/mozilla-central/rev/f7f62131998d
 +http://hg.mozilla.org/comm-central/rev/7ea34ef19dc4)

V.Fixed

Comment 12

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 364481 [details] [diff] [review]
patch2

a191=beltzner

Comment 13

[Dão Gottwald [:dao]]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/9d4ccf97e7cb