Storage template builder can't handle 64 bit integers

RESOLVED FIXED in mozilla1.9.2a1

Status

()

Core
XUL
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: mossop, Assigned: mossop)

Tracking

Trunk
mozilla1.9.2a1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

10 years ago
When the template builder encounters an integer in the result set it retrieves it as a 32 bit integer, truncating what may be a 64 bit integer.
(Assignee)

Comment 1

10 years ago
Created attachment 360299 [details] [diff] [review]
untested patch

Ought to cover it
(Assignee)

Comment 2

10 years ago
Created attachment 360501 [details] [diff] [review]
with tests

Adds tests. We cannot test the largest 64 bit integers because JS can't handle them exactly, which perhaps might argue that supporting 64-bit is unnecessary, but I don't think so.
Assignee: nobody → dtownsend
Attachment #360299 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #360501 - Flags: review?
(Assignee)

Updated

10 years ago
Attachment #360501 - Flags: review? → review?(enndeakin)

Comment 3

10 years ago
Comment on attachment 360501 [details] [diff] [review]
with tests

Looks OK, but it would be good to put the tests in the same directory as bug 378893.
Attachment #360501 - Flags: review?(enndeakin) → review+
(Assignee)

Comment 4

10 years ago
Not sure I understand, the tests are in the same directory, except that that directory doesn't exist yet since that bug isn't fixed.
(Assignee)

Comment 5

10 years ago
Moved the tests and landed in http://hg.mozilla.org/mozilla-central/rev/a55a3228e474
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1

Updated

10 years ago
Depends on: 483607
You need to log in before you can comment on or make changes to this bug.