476729 - Calculate a viewing rect relative to the canvas

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[(dormant account)]

currently viewingRect is partially bogus.
a) It contains negative values when toolbar is showing(in a non-frozen state)
ie instead of height changing, y is set to a -ve value
Same thing happens with the tab bar
b)when a frozen toolbar is showing, then viewingRect does not comprensate for it(screws up spacial nav)

Comment 1

[(dormant account)]

Attachment: workaround

In this patch I use math.max(0,) to normalize left/right(instead of fixing resizing code)

and iterate over widgets to find a frozen one that may overlap. It's suboptimal, but it solves the problem at the moment. A correct solution will take a little more effort.

Comment 2

[(dormant account)]

Attachment: using correct rects

I still would like to be able to compensate for frozen toolbar hanging over the viewport, but for now i'd like to get this landed.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 360611 [details] [diff] [review]
using correct rects

WidgetStack tries to be somewhat canvas-agnostic, so a better name would be viewportVisibleRect, I think. r=me with that change.

(I think losing the "public" viewingRect getter and replacing it with this one is OK, since the actual viewingRect is unlikely to be useful to external consumers anyways, and there aren't any other users of this that I know of.)

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Oh, and can you add a comment that mentions that we're relying on viewportBounds and viewingRect having the same origin? We do have some code that tries to support them being aligned differently, but don't rely on it in Fennec (I suspect it's buggy). Probably worth filing a followup to figure out what to do about that...

Comment 5

[(dormant account)]

pushed http://hg.mozilla.org/mobile-browser/rev/d57493bb00d2

Comment 6

[Brad Lassey [:blassey] (use needinfo?)]

I'm assuming we can close this out since the patch was pushed