47676 - HTTP auth password dialogbox is not localizable.

Status: VERIFIED FIXED

(Core :: Networking: HTTP, defect, P3)

Description

[Frank Tang]

reproduce procedure
1. use localize build ja/de/fr
2. visit http://www.w3.org/International/Group
The dialog is not localizable. The bad code is in 

mozilla/netwerk/protocol/http/src/nsHTTPChannel.cpp

2026 valeski      1.92          //TODO localize it!
2027 scc          1.155         nsAutoString message; 
message.AssignWithConversion("Enter username for "); 
2028 shaver       1.186         // later on change to only show realm and then 
host's info. 
2029 scc          1.155         message.AppendWithConversion(iChallenge);
2030 valeski      1.92          
2031                            // Get url
2032 warren       1.180         nsXPIDLCString urlCString; 
2033 warren       1.183         mURI->GetPrePath(getter_Copies(urlCString));
2034 shaver       1.186             
2035 warren       1.183         nsAutoString prePath = 
NS_ConvertToString(urlCString); // XXX i18n
2036 warren       1.180         rv = 
mPrompter->PromptUsernameAndPassword(nsnull,
2037                                                                      
message.GetUnicode(),
2038 warren       1.183                                                   
prePath.GetUnicode(),
2039 morse        1.201                                                   
nsIPrompt::SAVE_PASSWORD_PERMANENTLY,
2040 shaver       1.186                                                   
getter_Copies(userBuf),
2041                                                                      
getter_Copies(passwdBuf),
2042 warren       1.180                                                   
&retval);
2043 shaver       1.186         if (NS_FAILED(rv))
2044 gagan        1.129             return rv;

Please move these string into string bundle.

Comment 1

[Frank Tang]

this is localizability issue. Without it, we can not ship localized client. 
nsbeta3

Comment 2

[Frank Tang]

actual behavior
See English string "Enter username for " in localize build.

expect behavior
in localize build see these text translated into japanese/french/germany

Comment 3

[Warren Harris]

We've got a string bundle for this stuff: 
netwerk/resources/locale/en-US/necko.properties

This is gagan's code -- reassigning.

Comment 4

[Gagan]

http bugs to "Networking::HTTP"

Comment 5

[Darin Fisher]

removing stale nsbeta3 keyword.

Comment 6

[Gervase Markham [:gerv]]

If someone can suggest how this might be done, I'll have a go - but I can't find 
other examples of how it's done elsewhere... Do I really need to create a 
StringBundleService as suggested on 
http://www.mozilla.org/projects/intl/string-resources.html ?

Gerv

Comment 7

[tao]

yes, you need to use stringBundle to retrieve it from 'necko.properties'. You
should be able to find example code in mozilla with lxr.

Comment 8

[John G. Myers]

Sample code is in mailnews/compose/src/nsSmtpProtocol.cpp in 
nsSmtpProtocol::GetUsernamePassword()

Comment 9

[Gervase Markham [:gerv]]

darin: I should make the point here that I'm finding this a bit beyond me, and 
you shouldn't rely on me fixing it... Sorry about that :-( It's not at all as 
straightforward as I thought it was.

Gerv

Comment 10

[Jaime Rodriguez, Jr.]

This is targeted for 1.0, let's mark this one nsbranch- for this round.

Comment 11

[tao]

If we want more secured features, I'd suggest we take this.

Comment 12

[Cindy Roberts]

Marking nsbranch- as it was decided in the August bug triage that we wouldn't
have enough time in eMojo to fix this.  Let's revisit for MachV.

Comment 13

[Michele Carlson]

adding nsbeta1

Comment 14

[Denis Antrushin]

Doesn't this fixed in version 1.2 of nsHttpChannel.cpp (11 May 2001) ?
See nsHttpChannel::PromptForUserPass(), around lines 1548-1577...

Comment 15

[Darin Fisher]

denis: yeah, i think you are correct.  marking FIXED.

Comment 16

[Tom Everingham]

verified