476770 - WinCE CAB Creation NEEDS /compress flag

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[John Wolfe (:wolfe)]

Right now, the CABWIZ.EXE call to create a Windows Mobile Installer CAB does not pass in the /compress flag, resulting in a ~22MB CAB instead of a ~8MB CAB using compression.

Unfortunately, CABWIZ.EXE will not recognize "-compress" as a valid argument, and the bash shell corrupts any attempt to send a second argument of "/compress" into the CABWIZ.EXE application.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Can you use the cabwiz.ddf file and change the default to:

.Set Compress=ON

Comment 2

[(not currently active) Ted Mielczarek]

That file lives next to cabwiz.exe, apparently, so you'd have to edit the copy in the SDK. A possible solution here is to change the script that's calling makecab from a bash script to a Python script. The Python we ship with MozillaBuild is a native Win32 program, so it doesn't do path translation like the msys utils do, so you can pass /compress to makecab without it being turned into a path.

Comment 3

[Brad Lassey [:blassey] (use needinfo?)]

I tried editing the system qwide cabwiz.ddf next to cabwiz.exe and it had no effect.

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: calls python from the bash script

Comment 5

[(not currently active) Ted Mielczarek]

Comment on attachment 361958 [details] [diff] [review]
calls python from the bash script

This is truly awful. We need to rewrite this script.

Comment 6

[Brad Lassey [:blassey] (use needinfo?)]

pushed http://hg.mozilla.org/mobile-browser/rev/c226b5845f95

Comment 7

[Aakash Desai [:aakashd]]

verified FIXED via code inspection and the sheer size of the .cab file via mxr and build:

Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.3a1pre) Gecko/20090818 Fennec/1.0a3pre