47689 - ftp password dialogbox cannot be localized into non English.

Status: RESOLVED INVALID

(Core :: Internationalization, defect, P3)

Description

[Frank Tang]

use localized build (ja/fr/de) visit ftp://ftang@sweetlou/
 

Expect result-
The dialog title should show localized translation of "Password" and the dialog 
text show localized into local language in localized build.

Actual result-
The dialog title show "Passowrd" and 
I see "Enter password for "  and/or "Enter username and password for " in 
English 


the problem is in the following code
netwerk/protocol/ftp/src/nsFtpConnectionThread.cpp
827             message.AssignWithConversion("Enter username and password for 
"); //TODO localize it!
828             message.AppendWithConversion(host);
829 
830             nsAutoString realm = NS_ConvertToString(host);                   
// XXX i18n 
831             rv = proxyprompter->PromptUsernameAndPassword(nsnull,
832                                                           
message.GetUnicode(),
833                                                           
realm.GetUnicode(), nsIPrompt::SAVE_PASSWORD_PERMANENTLY,
834                                                           &user, &passwd, 
&retval);
835 



AND

902             title.AssignWithConversion("Password");
903             
904             nsXPIDLCString host;
905             rv = mURL->GetHost(getter_Copies(host));
906             if (NS_FAILED(rv)) return rv;
907             message.AssignWithConversion("Enter password for "); //TODO 
localize it!
908             message += mUsername;
909             message.AppendWithConversion(" on ");
910             message.AppendWithConversion(host);
911 
912             nsXPIDLCString prePath;
913             rv = mURL->GetPrePath(getter_Copies(prePath));
914             if (NS_FAILED(rv)) return rv;
915             rv = proxyprompter->PromptPassword(title.GetUnicode(),
916                                                message.GetUnicode(),
917                                                
NS_ConvertASCIItoUCS2(prePath).GetUnicode(), 
918                                                
nsIPrompt::SAVE_PASSWORD_PERMANENTLY,
919                                                &passwd, &retval);


We need to put these string into string bundle so we can localize it and ship a 
localized JA/DE/FR client. 
cvsblame show valeski is around the code. Assign to valeski

Comment 1

[Frank Tang]

localizability issue. nsbeta3

Comment 2

[Judson Valeski]

-> gagan

Comment 3

[Gagan]

robert-- welcome to necko!

Comment 4

[johng]

triage team:
we know this is important, but it is such a rare dialog and we have so many
other bug fixes that we are nsbeta3-.  However, we will accept a fix to this, we
just don't have the time to fix ourselves.  Another team might have the time and
can nsbeta3+ it.

Comment 5

[Gagan]

Hi dougt, welcome to necko :)

Comment 6

[Doug Turner (:dougt)]

Adjusting keywords.  

Comment 7

[Doug Turner (:dougt)]

setting milestone

Comment 8

[Teruko Kobayashi]

Changed QA contact to [e-mail].

Comment 9

[Doug Turner (:dougt)]

Attachment: Adds to string to the english necko property file.

Comment 10

[Doug Turner (:dougt)]

Attachment: makes ftp use the string bundle service...

Comment 11

[Doug Turner (:dougt)]

gagan, need a r=
darin, can you sr=

Comment 12

[Gagan]

I'd suggest you cache the bundleService with the handler so that you don't keep 
creating it each time for each connection[thread] object. Other than that 
r=gagan

Comment 13

[Doug Turner (:dougt)]

Thanks for the suggestion, but getting the service is not called the much.  
Usually it is not called at all.

Comment 14

[Andreas Becker]

Changing QA contact back to teruko for now.

Comment 15

[Jaime Rodriguez, Jr.]

looks like this one is fixed, but needs review and super-review. 

Comment 16

[Doug Turner (:dougt)]

Fix checked in.  r=[e-mail]. sr=[e-mail]

Comment 17

[Teruko Kobayashi]

Verified as fixed in 2001-05-30 JA build.

[e-mail], please test this on French and German build.

Comment 18

[Anna Cassidy]

Paul - can you check this out for French - I'll take a look at German

Comment 19

[Anna Cassidy]

For DE this dialog is now fully localised.  However if you enter an invalid
password and click OK the text in the Warning Dialog (login incorrect) is
unlocalised.  This string is not coming from within the language pack.

Comment 20

[selmer (gone)]

I'll keep this in the list for today.  Tomorrow it may be too late.

Comment 21

[Doug Turner (:dougt)]

Anna, that text comes from the server.  If the ftp server is localized, you 
should see localized text.