476933 - Colors in topic not parsed if in non-whitespace blurb with colon

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[Frosty]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.7) Gecko/20070914 3P_UVRM/1.00.1 Firefox/2.0.0.7
Build Identifier: ChatZilla 0.9.83

Trying to change Topic on channel recently, kept screwing up the colors.
%C9,1[Hello:Yes]%C11,1[Banana:No]%C4,1[DVDPlayer:Yes]%C14,1[SodaPop:Yes]

kept giving this as the changed Topic:
%C9,1[Hello:Yes]%%C11,1[Banana:No]%%C4,1[DVDPlayer:Yes]%%C14,1[SodaPop:Yes]

Double %'s .  This may be documented, but I didn't find it.
Only fix I could find, is a space between the end-bracket and the % color command for the next sequence:
%C9,1[Hello:Yes] %C11,1[Banana:No] %C4,1[DVDPlayer:Yes] %C14,1[SodaPop:Yes]

This works, but our Topic is max'd out as it is, and no extra room exists for spaces. 

-----
I'm gonna add this in here, as I dunno where annoyances / feature request go, do with it what you will. Copy/paste to appropriate area if needed.

I have registered versions of all IRC clients, but prefer chatzilla.  It's clean looking, and works extremely well.  Thanks for all your efforts.
As OP's for a very large IRC network, I have open so many channel tabs, it becomes impossible to see what is what.  All channels turn from tabs with names, to "..." or less.
The Option to: "[x] Tile Channel Tabs" so that multiple rows of channel tabs are displayed is becoming a necessity.  I simply cannot watch the channels I need/want to when they are all labeled ".."

Next, the channels fill constantly with Notices, connect messages, etc.  If it is something I need to see and happen to click off of it, it is sometimes difficult to find again until I click/click/click going through the many tabs.
[x] Send notices to: __________________ (channel name)
where you can enter a non-existent channel which ChatZilla will open and place notices in. Example:  [x] Send notices to: __#MyNotices___________ 

The Auto-Preform works very well, however at times commands are issued a bit too quick for some servers.  The most basic "delay xx" in preform to delay in seconds execution of Auto-Preforms.  Example: Delay 5 would delay 5 seconds.
or perhaps to avoid confusion with actual commands: /p delay xx which stands for /pause delay seconds.

These may have been addressed at some point, but I was unable to update / upgrade due to FF 3.x.x not supporting self signed site certificates.  I have found a work around, and may upgrade/update here soon.

Sorry if this broke protocol, listing multiple items.

Cheers.



Reproducible: Always

Steps to Reproduce:
1.Change Channel Topic with multiple colors and brackets
2. Open multiple channel tabs
3.Notices filling channel with spam
4. preforms too quick.

Comment 1

[Glen Mailer]

Different issues should be in separate bugs, i'll make some notes here and let you split them up yourself.

Colour bug: is valid, should be in its own bug at then we can look into it properly

Channel Tabs: ChatZilla's shortcomings when opening many tabs are well known, workarounds exist, and there are a few bugs on this sort of thing filed already

Message redirection is a duplicate of an existing bug

A delay command is a reasonable request, and should have its own bug.

Comment 2

[:Gijs (he/him)]

(In reply to comment #1)
> <snip>
> 
> A delay command is a reasonable request, and should have its own bug.


Filed bug 480936.

Comment 3

[:Gijs (he/him)]

Attachment: Patch

I can't say this patch particularly makes me *happy*, but it works...

Comment 4

[James Ross]

Comment on attachment 410685 [details] [diff] [review]
Patch

Wow, magic.

replaceColorCodes() just gets slower and slower, but screw it, it's only for sending text. :)

Comment 5

[:Gijs (he/him)]

http://hg.mozilla.org/chatzilla/rev/b0f513af0be7