477001 - Configure error on solaris cmp: illegal option -- b

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Leon Sha]

$ autoconf-2.13
$ ./configure

...........
cmp: illegal option -- b
usage: cmp [-l] [-s] file1 file2 [skip1] [skip2]

Comment 1

[Leon Sha]

Attachment: Use cmp -s instead.

Comment 2

[Jim Mathies [:jimm]]

Comment on attachment 360665 [details] [diff] [review]
Use cmp -s instead.

I'm not the right reviewer for this. Build config is what your looking for - 

http://www.mozilla.org/owners.html#build-config

Comment 3

[Wan-Teh Chang]

Comment on attachment 360665 [details] [diff] [review]
Use cmp -s instead.

Leon,

You should add the original author of this code to review
this patch, because the -s option has the opposite effect
of -b.

It is correct that the -b option is non-portable.  The
Single Unix Specification Version 3 only specifies the
-l and -s options for cmp:
http://www.opengroup.org/onlinepubs/009695399/utilities/cmp.html

The cmp(1) man page on Linux says -b means "Print differing bytes",
and -s means "Output nothing; yield exit status only."  Unless
I know the intention of the original author, I don't know if
what the correct fix is (simply removing -b, or replacing -b
by -s).

Comment 4

[Wan-Teh Chang]

Comment on attachment 360665 [details] [diff] [review]
Use cmp -s instead.

r=wtc.

OK, I found the checkin that added the code that uses
cmp -b:
http://hg.mozilla.org/mozilla-central/diff/332c6aaee89c/configure.in

It's clearly a copy of another piece of code, which uses
cmp -s.  So I think this patch is correct.

Kairo may want to review this, too.

Comment 5

[Robert Kaiser]

Comment on attachment 360665 [details] [diff] [review]
Use cmp -s instead.

Thanks for catching this, apparently the -b option is GNU-specific or something like that and it may just have slipped in when testing different approaches to the problem.
This should go into 1.9.1 as well, by the way.

Comment 6

[Leon Sha]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/798cdf019ef7
http://hg.mozilla.org/mozilla-central/rev/2e548d4535df