Closed Bug 477128 Opened 11 years ago Closed 11 years ago
Wrapper("foo") shouldn't throw
We need a way to check if an argument, that was passed to a component's method which takes it as a string, is actually a string, and not a js object that implements toString. Blake suggested using XPCNativeWrapper(theArgument), but that wouldn't work since XPCNativeWrapper("foo") apparently throws.
11 years ago
This blocks 454363, so we should get it on trunk and 191 asap, and it is a 191 blocker.
Flags: blocking1.9.1? → blocking1.9.1+
Priority: -- → P2
Flags: blocking184.108.40.206? → blocking220.127.116.11+
http://hg.mozilla.org/mozilla-central/rev/4e892b36c3f5 and http://hg.mozilla.org/releases/mozilla-1.9.1/rev/6cdcdfdbe838
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment on attachment 360806 [details] [diff] [review] Fix This applies as-is.
Attachment #360806 - Flags: approval18.104.22.168?
Comment on attachment 360806 [details] [diff] [review] Fix Approved for 22.214.171.124, a=dveditz for release-drivers
Attachment #360806 - Flags: approval126.96.36.199? → approval188.8.131.52+
Fixed on the 1.9.0 branch.
No unit tests for this change?
http://hg.mozilla.org/mozilla-central/rev/a77ca9432e65 and http://hg.mozilla.org/releases/mozilla-1.9.1/rev/b467060a5be9 and test_wrappers.html revision: 1.6 on CVS trunk.
You need to log in before you can comment on or make changes to this bug.