Closed Bug 477128 Opened 11 years ago Closed 11 years ago

XPCNativeWrapper("foo") shouldn't throw

Categories

(Core :: XPConnect, defect, P2)

x86
macOS
defect

Tracking

()

RESOLVED FIXED

People

(Reporter: mano, Assigned: mrbkap)

References

Details

(Keywords: fixed1.9.1, verified1.9.0.9)

Attachments

(2 files)

We need a way to check if an argument, that was passed to a component's method which takes it as a string, is actually a string, and not a js object that implements toString. Blake suggested using XPCNativeWrapper(theArgument), but that wouldn't work since XPCNativeWrapper("foo") apparently throws.
Attached patch FixSplinter Review
Assignee: nobody → mrbkap
Status: NEW → ASSIGNED
Attachment #360806 - Flags: superreview?(jst)
Attachment #360806 - Flags: review?(jst)
Attachment #360806 - Flags: superreview?(jst)
Attachment #360806 - Flags: superreview+
Attachment #360806 - Flags: review?(jst)
Attachment #360806 - Flags: review+
Flags: blocking1.9.1?
Flags: blocking1.9.0.8?
This blocks 454363, so we should get it on trunk and 191 asap, and it is a 191 blocker.
Flags: blocking1.9.1? → blocking1.9.1+
Priority: -- → P2
Flags: blocking1.9.0.8? → blocking1.9.0.8+
Comment on attachment 360806 [details] [diff] [review]
Fix

This applies as-is.
Attachment #360806 - Flags: approval1.9.0.8?
Comment on attachment 360806 [details] [diff] [review]
Fix

Approved for 1.9.0.8, a=dveditz for release-drivers
Attachment #360806 - Flags: approval1.9.0.8? → approval1.9.0.8+
Fixed on the 1.9.0 branch.
Keywords: fixed1.9.0.8
No unit tests for this change?
Verified for 1.9.0.9 with mochitest on tinderbox today.
You need to log in before you can comment on or make changes to this bug.