477128 - XPCNativeWrapper("foo") shouldn't throw

Status: RESOLVED FIXED

(Core :: XPConnect, defect, P2)

Description

[Asaf Romano (gone)]

We need a way to check if an argument, that was passed to a component's method which takes it as a string, is actually a string, and not a js object that implements toString. Blake suggested using XPCNativeWrapper(theArgument), but that wouldn't work since XPCNativeWrapper("foo") apparently throws.

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Fix

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

This blocks 454363, so we should get it on trunk and 191 asap, and it is a 191 blocker.

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

http://hg.mozilla.org/mozilla-central/rev/4e892b36c3f5 and http://hg.mozilla.org/releases/mozilla-1.9.1/rev/6cdcdfdbe838

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 360806 [details] [diff] [review]
Fix

This applies as-is.

Comment 5

[Daniel Veditz [:dveditz]]

Comment on attachment 360806 [details] [diff] [review]
Fix

Approved for 1.9.0.8, a=dveditz for release-drivers

Comment 6

[Blake Kaplan (:mrbkap) (inactive)]

Fixed on the 1.9.0 branch.

Comment 7

[Al Billings [:abillings - ex-MoCo]]

No unit tests for this change?

Comment 8

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Mochitest

Comment 9

[Blake Kaplan (:mrbkap) (inactive)]

http://hg.mozilla.org/mozilla-central/rev/a77ca9432e65 and http://hg.mozilla.org/releases/mozilla-1.9.1/rev/b467060a5be9 and test_wrappers.html revision: 1.6 on CVS trunk.

Comment 10

[Al Billings [:abillings - ex-MoCo]]

Verified for 1.9.0.9 with mochitest on tinderbox today.