Closed Bug 477144 Opened 11 years ago Closed 11 years ago
Check searchplugin list ahead of 3
This seems strange: http://hg.mozilla.org/releases/l10n-mozilla-1.9.1/bg/file/60f2d9d0505d/browser/searchplugins/list.txt because it has no localized searches even though there are some alongside it in the dir. Here are the changes to that file http://hg.mozilla.org/releases/l10n-mozilla-1.9.1/bg/log/60f2d9d0505d/browser/searchplugins/list.txt and the change at "2009-01-24 14:18 +0200" is responsible. Same issue in l10n-central. It's not too late to fix this for 3.1b3 if you move quickly, and Axel is happy to take a changeset bump.
Good catch Nick, thanks. Here's the exact change that need to be reverted: http://hg.mozilla.org/releases/l10n-mozilla-1.9.1/bg/diff/210967c19a12/browser/searchplugins/list.txt And here's the reference: https://wiki.mozilla.org/L10n:Firefox_web_services_status:bg Ognyan, please submit a patch for a review before actually landing anything. Thanks!
We should take this bustage fix for Beta 3. Stas, review the patch for me? I guess we should then do a bustage fix landing for Ogi.
Attachment #361872 - Flags: review?(stas)
just noticed this was caught and backed out. nice work. In the future, how can we catch these issues earlier? Particularly for QA, given that we rarely test l10n nightlies, what suggestions can we do ahead of time, to ensure these kind of mistakes dont get into our released builds?
Comment on attachment 361872 [details] [diff] [review] revert accidental check-in r+
Attachment #361872 - Flags: review?(stas) → review+
Pushed to both central and 1.9.1. Ogi, please pull and update your local repos, and merge if needed. http://hg.mozilla.org/releases/l10n-mozilla-1.9.1/bg/rev/ad9bf4e44d7d241a727c48a96912ebf0ced91a82 and http://hg.mozilla.org/l10n-central/bg/rev/2fbc4bcfabd1b1d0ac27b9a59fb262a12b9c5868. /me mumbles something about mystic greek pseudo animals in mazes to Tony.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Thanks Gandalf for the review and Axel for landing the patch. Sorry I wasn't around to help.
(In reply to comment #3) > In the future, how can we catch these issues earlier? Particularly for QA, > given that we rarely test l10n nightlies, what suggestions can we do ahead of > time, to ensure these kind of mistakes dont get into our released builds? Axel beat me to the punch, but I'll write it anyway - Mynotaur.
You need to log in before you can comment on or make changes to this bug.