Closed Bug 477170 Opened 12 years ago Closed 12 years ago

Removing Windows 95 in configure.in

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: xfsunoles, Assigned: xfsunoles)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 3 obsolete files)

I will remove Windows 95 code in configure.in without remmoving NSPR code. I will make a patch for it. Do I need to do same to js one?
Yes, for any changes you make to configure.in, please make the same changes in js/src/configure.in (if the same code exists there).
Attached patch Tell it so (obsolete) — Splinter Review
Assignee: nobody → xfsunoles
Status: NEW → ASSIGNED
Attachment #360941 - Flags: review?(ted.mielczarek)
Comment on attachment 360941 [details] [diff] [review]
Tell it so

 # Note: OS_TARGET should be specified on the command line for gmake.
-# When OS_TARGET=WIN95 is specified, then a Windows 95 target is built.
 # The difference between the Win95 target and the WinNT target is that
 # the WinNT target uses Windows NT specific features not available
 # in Windows 95. The Win95 target will run on Windows NT, but (supposedly)

Just kill this whole comment block, since you're removing the distinction anyway.

-if test "$OS_TARGET" = "WIN95"; then
-    OS_RELEASE="4.0"
+fi
 fi

Looks like you missed removing the 'fi', and added an extra one, to boot!

Looks good otherwise, thanks for the cleanup.
Attachment #360941 - Flags: review?(ted.mielczarek) → review+
Attached patch Try Again this time (obsolete) — Splinter Review
Attachment #360941 - Attachment is obsolete: true
Attached file Update to the Trunk (obsolete) —
Attachment #363934 - Attachment is obsolete: true
Attached patch Current Trunk 2Splinter Review
I forget to modifed both line. 

ted, it is ready to be checkin.
Attachment #374121 - Attachment is obsolete: true
http://hg.mozilla.org/mozilla-central/rev/2f8573469f72
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Flags: in-testsuite-
Target Milestone: --- → mozilla1.9.2a1
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.