If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Removing Windows 95 in configure.in

RESOLVED FIXED in mozilla1.9.2a1

Status

()

Core
Build Config
RESOLVED FIXED
9 years ago
8 years ago

People

(Reporter: Jonathan Steele, Assigned: Jonathan Steele)

Tracking

(Blocks: 1 bug)

Trunk
mozilla1.9.2a1
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 3 obsolete attachments)

(Assignee)

Description

9 years ago
I will remove Windows 95 code in configure.in without remmoving NSPR code. I will make a patch for it. Do I need to do same to js one?
Yes, for any changes you make to configure.in, please make the same changes in js/src/configure.in (if the same code exists there).
(Assignee)

Comment 2

9 years ago
Created attachment 360941 [details] [diff] [review]
Tell it so
Assignee: nobody → xfsunoles
Status: NEW → ASSIGNED
Attachment #360941 - Flags: review?(ted.mielczarek)
Comment on attachment 360941 [details] [diff] [review]
Tell it so

 # Note: OS_TARGET should be specified on the command line for gmake.
-# When OS_TARGET=WIN95 is specified, then a Windows 95 target is built.
 # The difference between the Win95 target and the WinNT target is that
 # the WinNT target uses Windows NT specific features not available
 # in Windows 95. The Win95 target will run on Windows NT, but (supposedly)

Just kill this whole comment block, since you're removing the distinction anyway.

-if test "$OS_TARGET" = "WIN95"; then
-    OS_RELEASE="4.0"
+fi
 fi

Looks like you missed removing the 'fi', and added an extra one, to boot!

Looks good otherwise, thanks for the cleanup.
Attachment #360941 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Comment 4

9 years ago
Created attachment 363934 [details] [diff] [review]
Try Again this time
Attachment #360941 - Attachment is obsolete: true
(Assignee)

Comment 5

9 years ago
Created attachment 374121 [details]
Update to the Trunk
Attachment #363934 - Attachment is obsolete: true
(Assignee)

Comment 6

9 years ago
Created attachment 379821 [details] [diff] [review]
Current Trunk 2

I forget to modifed both line. 

ted, it is ready to be checkin.
Attachment #374121 - Attachment is obsolete: true
Keywords: checkin-needed
Blocks: 379342
http://hg.mozilla.org/mozilla-central/rev/2f8573469f72
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Flags: in-testsuite-
Target Milestone: --- → mozilla1.9.2a1
Blocks: 542767
You need to log in before you can comment on or make changes to this bug.