Closed Bug 477333 Opened 11 years ago Closed 11 years ago

[FIX]"ASSERTION: out of bounds" with contentEditable, table, overflow:scroll

Categories

(Core :: DOM: Editor, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: jruderman, Assigned: bzbarsky)

References

(Blocks 2 open bugs)

Details

(Keywords: assertion, testcase)

Attachments

(2 files)

Attached file testcase
WARNING: Someone passed native anonymous content directly into frame construction.  Stop doing that!: file /Users/jruderman/central/layout/base/nsCSSFrameConstructor.cpp, line 7924

###!!! ASSERTION: out of bounds: 'PRInt32(aIndex) >= 0 && aIndex <= l', file /Users/jruderman/central/layout/base/nsChildIterator.h, line 132

###!!! ASSERTION: anonymous nodes should not be in child lists: '!aOldChild->IsRootOfAnonymousSubtree()', file /Users/jruderman/central/layout/base/nsCSSFrameConstructor.cpp, line 12404
the warning was introduced in bug 476087, which hints that this might be dupe of bug 476670
I hate editor.  :(
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Attachment #361273 - Flags: superreview?(dbaron)
Attachment #361273 - Flags: review?(dbaron)
Summary: "ASSERTION: out of bounds" with contentEditable, table, overflow:scroll → [FIX]"ASSERTION: out of bounds" with contentEditable, table, overflow:scroll
Am I correct that all you're changing here is removing the assertion and swapping the order of the then/else?
Yeah, basically.  I'm just avoiding making any seek() calls in the non-XBL case when the index is -1.
Attachment #361273 - Flags: superreview?(dbaron)
Attachment #361273 - Flags: superreview+
Attachment #361273 - Flags: review?(dbaron)
Attachment #361273 - Flags: review+
Comment on attachment 361273 [details] [diff] [review]
Stupid first-letter case...

Ah, the else is now an else if; that's the part I missed.
Pushed http://hg.mozilla.org/mozilla-central/rev/c224a8b5416f
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Flags: in-testsuite? → in-testsuite+
You need to log in before you can comment on or make changes to this bug.