Closed Bug 47735 Opened 25 years ago Closed 21 years ago

Toolbar menubuttons have inconsistent borders

Categories

(SeaMonkey :: Themes, defect, P4)

PowerPC
Mac System 8.5
defect

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: hsivonen, Assigned: lordpixel)

References

Details

(Keywords: classic)

Build ID: 2000080420-M18 Classic theme Back/Forward are different Reload/stop when hovered upon. Steps to reproduce: 1) Go to a couple of pages to enable the Back button 2) Move the mouse cursor over the Back button icon 3) Move the mouse cursor over the Back button arrow 4) Move the mouse cursor over the Reload button icon Actual results: Different borders are displayed Expected results: Expected points 3 and 4 to display a border similar to point 2.
Actually, what we expect is for point 2 to display the same border as point 3; point 4's border is perfectly fine. In Netscape 4.x, mouseOvers on navigation buttons cause a black outer border with an inner bevel border to appear. Currently in mac classic, the Reload button and arrow buttons on the Forward/Back buttons display exactly that. When we mouseOver the Forward/Back button icon, though, we do not get this black border. This is the real bug. I'm working on it.
Status: NEW → ASSIGNED
The real meat of the issue, here, is that the "Back" and "Reload" buttons inherit different XBL/CSS for their behavior, which is why the mouseOvers are different. The "Reload" button exhibits the proper behavior, so it is the "Back" button that has issues: First off, the Back button is actually composed of two boxes which are peers: one that contains the big back <button>, and the other that contains the drop down arrow <image>. (You can view the actual XBL in classic/global/skin/menubuttonBindings.xml#menubutton-toolbar-top, and the appropriate CSS in classic/global/skin/menubutton.css) The problem essentially boils down to an event-handling one. When you mouse-over the drop-down arrow <image>, it passes the event up the hierarchy to its parent, the larger Back button containing both boxes, and it handles the event and draws the appropriate border. However, when you mouse-over the big back <button>, which is a child of the larger Back button, it handles its own event so the larger Back button never sees it. Since the larger Back button never sees it, it cannot draw the appropriate border on mouse-over. If you want, take a look at the appropriate files and let me know if you come up with a patch. I've been looking at this for some time and haven't found a good solution yet.
Updating QA Contact to pmac@netscape.com
QA Contact: paw → pmac
Summary: Toolbar buttons have inconsistent borders → Toolbar menubuttons have inconsistent borders
Reassigning all Nikhil's bugs to me as he is no longer here.
Assignee: nbhatla → andreww
Status: ASSIGNED → NEW
Status: NEW → ASSIGNED
Depends on: 53823
Themes Triage Team P4
Priority: P3 → P4
Blocks: 91504
Actually, the hover behavior of these two-part toolbar buttons is slightly different. 1. Hovering over the drop-down arrow causes the button border to display properly. 2. Hovering over the very outside border of either part of the button causes proper display. 3. Hovering over the "content" area of the button exclusing the aforementioned outside edge causes incorrect display.
reassigning some of my mac classic bugs so they dont fall off into space...
Assignee: andreww → lordpixel
Status: ASSIGNED → NEW
This bug is targeted at a Mac classic platform/OS, which is no longer supported by mozilla.org. Please re-target it to another platform/OS if this bug applies there as well or resolve this bug. I will resolve this bug as WONTFIX in four weeks if no action has been taken. To filter this and similar messages out, please filter for "mac_cla_reorg".
I cannot confirm this behaviour in MacOS X with a recent build. Because we are not working on anything dealing with old Mac since 1.3.1 anymore, I mark this "WONTFIX". In case that it reoccurs in MacOS X, please file a new bug.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → WONTFIX
Product: Core → SeaMonkey
You need to log in before you can comment on or make changes to this bug.