477531 - Support the CSS3 :indeterminate pseudoclass

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Michael Ventnor]

Attachment: Patch

Now that we support indeterminate checkboxes on all platforms, it would be nice to implement this pseudoclass to make it even more useful. Webkit supports it, as did Tasman when it was still relevant...

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 361198 [details] [diff] [review]
Patch

Looks good to me, but I'd like bzbarsky to look at it as well since he knows the event state stuff better than I do.

I think you should also add a mochitest that tests that dynamic changes work correctly, i.e., that indeterminate starts and stops matching based on the changes to the DOM property.

Comment 2

[Boris Zbarsky [:bzbarsky]]

It would also be good to have a test (mochitest, probably?) that tests that type changes correctly update :indeterminate.  I think they should, since we generally capture state changes across attr changes now, but worth checking.

Other than that, looks ok.  The invalidation living where it does still bothers me, but I don't have a better proposal that wouldn't involve invalidating on those "internal" changes you make there.

Comment 3

[Michael Ventnor]

Attachment: Patch 2

I added both requested tests as a single mochitest referencing this bug.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 361448 [details] [diff] [review]
Patch 2

Add a test that setting indeterminate back to false also works, and looks great.

Comment 5

[Michael Ventnor]

Attachment: Patch 3

No worries.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Pushed http://hg.mozilla.org/mozilla-central/rev/58c758340aa5