477596 - [Fennec] xpcshell unittest: test_update/unit/test_0020_general.js fails to find updates when >1 is available

Status: VERIFIED WORKSFORME

(Toolkit :: Application Update, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

in testing the xpcshell unit tests on fennec, the file test_update/unit/test_0020_general.js contains a set of update related tests by passing in a .xml file is AUS data.  There is 1 (out of 7 tests) case which fails to work.  It results in 0 updates found when it expects 3.  If I remove this specific test, all the other tests pass.

To run this by hand, here is a command line (substitute your paths):
home/mozilla/mozilla/mobile_debug/xulrunner/dist/bin/xpcshell -f /home/mozilla/mozilla/mobile_debug/xulrunner/_tests/xpcshell/head.js -f /home/mozilla/mozilla/mobile_debug/xulrunner/_tests/xpcshell-simple/test_update/unit/head_update.js -f /home/mozilla/mozilla/mobile_debug/xulrunner/_tests/xpcshell-simple/test_update/unit/test_0020_general.js -f /home/mozilla/mozilla/mobile_debug/xulrunner/_tests/xpcshell/tail.js -f /home/mozilla/mozilla/mobile_debug/xulrunner/_tests/xpcshell-simple/test_update/unit/tail_update.js -f /home/mozilla/mozilla/mobile_debug/xulrunner/_tests/xpcshell/execute_test.js


for more reference, here is a document outlining how to run these tests on Maemo and/or the fennec desktop:
https://wiki.mozilla.org/Mobile/Fennec_Xpcshell

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

moving to toolkit application update as this is specific to a test, not fennec.

http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/update/test/unit/test_0020_general.js

Comment 2

[Robert Strong (they/them - no direct email)]

Could you check if commenting out the following lines makes the test pass?
http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/update/src/nsUpdateService.js.in#2683

var brandStrings = sbs.createBundle(URI_BRAND_PROPERTIES);
var brandShortName = brandStrings.GetStringFromName("brandShortName");
this._update.statusText = updateStrings.formatStringFromName("verificationError",
                                                             [brandShortName], 1);

Comment 3

[Robert Strong (they/them - no direct email)]

sorry, commented in the wrong bug

Comment 4

[Robert Strong (they/them - no direct email)]

Joel, per your bug 477594 comment #23 - does this test now pass?

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

yes, this test passes and I have confirmed multiple times both on fennec-linux and fennec-maemo

Comment 6

[Robert Strong (they/them - no direct email)]

This was most likely fixed by bug 493805 or one of the other test cleanup bugs I landed... resolving -> wfm