4776 - [PP]Downloaded files are all TEXT files on the Macintosh.

Status: VERIFIED WORKSFORME

(Core :: XPCOM, defect, P2)

Description

[mcmullen]

In Apprunner, type a URL of a file on an http server that is not an html file
(such as a .exe file). The download dialog appears. Type in your destingation
file path.

The download works, but the files are always text.

We need to

1. Provide an overload of nsFileSpec.Create() that can take a mime type, and sets
the creator and signature.

2. Enhance nsFileSpec.Create() so that it sniffs the file suffix (if any) and
sets the type and creator using internet config.

Comment 1

[don]

Set target milestone to M5, changed priority to P2, and component to XP File
Handling.

John, do we need to do this sooner?

Comment 2

[mcmullen]

Well, depends how much dogfoodhood is required.

If the download dialog only needs to be sufficient for downloading M5, and if M5
is an hqx file, then text is fine. Since the user has to drag the file onto
Stuffit Expander anyway, there is no issue in this case.

There's a further issue here, too. What about the "action" preference for
downloaded files (eg, launching Stuffit Expander automatically)?

So if we are supposed to allow end-user type friendliness in M4 that will allow
people to download and install M5, we have a long, long way to go.

Comment 3

[don]

Changed target milestone to M7.

Comment 4

[don]

Move this to M8 until we can spend some more time worry about Internet Config
support ...

Comment 5

[Warren Harris]

We need to make sure our new http and ftp code can deal with mac type/creator
codes.

Comment 6

[mcmullen]

The solution here was simple. I knew what to do. This was here just to remind me.

It was assigned to Warren, because he and dp barged in and forcibly seized
ownership of all file i/o. Why does valeski now have this bug?

Comment 7

[chris hofmann]

sounds like it need internet config support.  m10?

Comment 8

[chris hofmann]

sounds like it need internet config support.  m10?

Comment 9

[Steve Dagley]

Yes, I've talked to valeski about using Internet Config to get the mime type to
Mac file type/creator matching rather than the current hardcoded values.  Once my
last bug M8 goes poof I'll take a look at it to see if we can get it in with the
Necko landing in M9.

Comment 10

[Judson Valeski]

I'm confused. Is the binary data being written to disk, being written as ascii
(thus corruption). Or is this an issue w/ the default file type specified in the
dowload file dialog?

Comment 11

[Judson Valeski]

this should be gone now.

Comment 12

[Tom Everingham]

Verified working build 2000010308.

Comment 13

[Eli Goldberg]

Bulk moving to XPCOM, in preparation for removal of XP File Handling component. 
(XPFH has received two bugs in ~5 months, and is no longer in active use.)