477666 - appcache namespaces broken after an update

Status: RESOLVED FIXED

(Core :: Networking: Cache, defect)

Description

[Dave Camp (:dcamp)]

Attachment: fix

After an application cache has been updated, but before a page has swapCache()'ed to the new cache, the old one is not properly allowing whitelist entries.

This is due to a sql problem in mStatement_FindNamespaceEntry, which includes the logic for choosing the most recent active cache/clientID.  This breaks because the current cache won't be the active cache, and isn't necessary because we already have a specific clientID.

Comment 1

[Johnny Stenback (:jst)]

blocking- as this doesn't seem like something that tons of users are going to be hurt by, but this does seem like something we probably should just take, given that there's a patch already. Please request approval once the patch has reviews etc.

Comment 2

[Dave Camp (:dcamp)]

http://hg.mozilla.org/mozilla-central/rev/78038be8f0f2

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 361331 [details] [diff] [review]
fix

a191=beltzner

Comment 4

[Dave Camp (:dcamp)]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/d4b0a0cfddff