Closed Bug 477666 Opened 11 years ago Closed 11 years ago

appcache namespaces broken after an update

Categories

(Core :: Networking: Cache, defect)

defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: dcamp, Assigned: dcamp)

Details

(Keywords: fixed1.9.1)

Attachments

(1 file)

Attached patch fixSplinter Review
After an application cache has been updated, but before a page has swapCache()'ed to the new cache, the old one is not properly allowing whitelist entries.

This is due to a sql problem in mStatement_FindNamespaceEntry, which includes the logic for choosing the most recent active cache/clientID.  This breaks because the current cache won't be the active cache, and isn't necessary because we already have a specific clientID.
Flags: blocking1.9.1?
Attachment #361331 - Flags: superreview?(bzbarsky)
Attachment #361331 - Flags: review?(honzab.moz)
Attachment #361331 - Attachment is patch: true
Attachment #361331 - Attachment mime type: application/octet-stream → text/plain
Attachment #361331 - Flags: superreview?(bzbarsky) → superreview+
Assignee: nobody → dcamp
blocking- as this doesn't seem like something that tons of users are going to be hurt by, but this does seem like something we probably should just take, given that there's a patch already. Please request approval once the patch has reviews etc.
Flags: blocking1.9.1? → blocking1.9.1-
Attachment #361331 - Flags: review?(honzab.moz) → review+
Attachment #361331 - Flags: approval1.9.1?
http://hg.mozilla.org/mozilla-central/rev/78038be8f0f2
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment on attachment 361331 [details] [diff] [review]
fix

a191=beltzner
Attachment #361331 - Flags: approval1.9.1? → approval1.9.1+
Flags: in-testsuite+
You need to log in before you can comment on or make changes to this bug.