appcache namespaces broken after an update

RESOLVED FIXED

Status

()

RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: dcamp, Assigned: dcamp)

Tracking

({fixed1.9.1})

unspecified
fixed1.9.1
Points:
---
Bug Flags:
blocking1.9.1 -
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
Created attachment 361331 [details] [diff] [review]
fix

After an application cache has been updated, but before a page has swapCache()'ed to the new cache, the old one is not properly allowing whitelist entries.

This is due to a sql problem in mStatement_FindNamespaceEntry, which includes the logic for choosing the most recent active cache/clientID.  This breaks because the current cache won't be the active cache, and isn't necessary because we already have a specific clientID.
Flags: blocking1.9.1?
Attachment #361331 - Flags: superreview?(bzbarsky)
Attachment #361331 - Flags: review?(honzab.moz)
Attachment #361331 - Attachment is patch: true
Attachment #361331 - Attachment mime type: application/octet-stream → text/plain
Attachment #361331 - Flags: superreview?(bzbarsky) → superreview+
(Assignee)

Updated

10 years ago
Assignee: nobody → dcamp
blocking- as this doesn't seem like something that tons of users are going to be hurt by, but this does seem like something we probably should just take, given that there's a patch already. Please request approval once the patch has reviews etc.
Flags: blocking1.9.1? → blocking1.9.1-
Attachment #361331 - Flags: review?(honzab.moz) → review+
(Assignee)

Updated

10 years ago
Attachment #361331 - Flags: approval1.9.1?
(Assignee)

Comment 2

10 years ago
http://hg.mozilla.org/mozilla-central/rev/78038be8f0f2
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Comment on attachment 361331 [details] [diff] [review]
fix

a191=beltzner
Attachment #361331 - Flags: approval1.9.1? → approval1.9.1+

Updated

10 years ago
Flags: in-testsuite+
You need to log in before you can comment on or make changes to this bug.