manifest attribute not handled in xhtml

RESOLVED FIXED

Status

()

RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: dcamp, Assigned: dcamp)

Tracking

({fixed1.9.1})

unspecified
x86
macOS
fixed1.9.1
Points:
---
Bug Flags:
blocking1.9.1 -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

10 years ago
Created attachment 361333 [details] [diff] [review]
fix

The manifest attribute for listing offline caches isn't handled in xhtml pages.
Flags: blocking1.9.1?
Attachment #361333 - Flags: superreview?(jst)
Attachment #361333 - Flags: review?(jst)
Not going to block on this. But we should take the patch...
Flags: blocking1.9.1? → blocking1.9.1-
Comment on attachment 361333 [details] [diff] [review]
fix

+  if (aNameSpaceID == kNameSpaceID_XHTML &&
+      aTagName == nsGkAtoms::html) {

Maybe reverse those checks as the namespace check is likely to be true for most nodes in an XHTML document, but the tag check is likely to be true only for a few elements per document at most.

r+sr=jst
Attachment #361333 - Flags: superreview?(jst)
Attachment #361333 - Flags: superreview+
Attachment #361333 - Flags: review?(jst)
Attachment #361333 - Flags: review+
Attachment #361333 - Flags: approval1.9.1+
(Assignee)

Comment 3

10 years ago
Created attachment 361487 [details]
patch as landed
(Assignee)

Comment 4

10 years ago
http://hg.mozilla.org/mozilla-central/rev/4fec2720b006
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/c210f70fcbcf
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Keywords: fixed1.9.1
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.