Closed Bug 477667 Opened 11 years ago Closed 11 years ago

manifest attribute not handled in xhtml

Categories

(Core :: DOM: Core & HTML, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: dcamp, Assigned: dcamp)

Details

(Keywords: fixed1.9.1)

Attachments

(2 files)

Attached patch fixSplinter Review
The manifest attribute for listing offline caches isn't handled in xhtml pages.
Flags: blocking1.9.1?
Attachment #361333 - Flags: superreview?(jst)
Attachment #361333 - Flags: review?(jst)
Not going to block on this. But we should take the patch...
Flags: blocking1.9.1? → blocking1.9.1-
Comment on attachment 361333 [details] [diff] [review]
fix

+  if (aNameSpaceID == kNameSpaceID_XHTML &&
+      aTagName == nsGkAtoms::html) {

Maybe reverse those checks as the namespace check is likely to be true for most nodes in an XHTML document, but the tag check is likely to be true only for a few elements per document at most.

r+sr=jst
Attachment #361333 - Flags: superreview?(jst)
Attachment #361333 - Flags: superreview+
Attachment #361333 - Flags: review?(jst)
Attachment #361333 - Flags: review+
Attachment #361333 - Flags: approval1.9.1+
Attached file patch as landed
http://hg.mozilla.org/mozilla-central/rev/4fec2720b006
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/c210f70fcbcf
Status: NEW → RESOLVED
Closed: 11 years ago
Keywords: fixed1.9.1
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.