Closed
Bug 477667
Opened 17 years ago
Closed 17 years ago
manifest attribute not handled in xhtml
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: dcamp, Assigned: dcamp)
Details
(Keywords: fixed1.9.1)
Attachments
(2 files)
|
2.79 KB,
patch
|
jst
:
review+
jst
:
superreview+
jst
:
approval1.9.1+
|
Details | Diff | Splinter Review |
|
2.17 KB,
application/octet-stream
|
Details |
The manifest attribute for listing offline caches isn't handled in xhtml pages.
Flags: blocking1.9.1?
Attachment #361333 -
Flags: superreview?(jst)
Attachment #361333 -
Flags: review?(jst)
Comment 1•17 years ago
|
||
Not going to block on this. But we should take the patch...
Flags: blocking1.9.1? → blocking1.9.1-
Comment 2•17 years ago
|
||
Comment on attachment 361333 [details] [diff] [review]
fix
+ if (aNameSpaceID == kNameSpaceID_XHTML &&
+ aTagName == nsGkAtoms::html) {
Maybe reverse those checks as the namespace check is likely to be true for most nodes in an XHTML document, but the tag check is likely to be true only for a few elements per document at most.
r+sr=jst
Attachment #361333 -
Flags: superreview?(jst)
Attachment #361333 -
Flags: superreview+
Attachment #361333 -
Flags: review?(jst)
Attachment #361333 -
Flags: review+
Updated•17 years ago
|
Attachment #361333 -
Flags: approval1.9.1+
| Assignee | ||
Comment 3•17 years ago
|
||
| Assignee | ||
Comment 4•17 years ago
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•