477735 - XPCOMUtils.generateQI should handle nulls in argument array

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: make generateQI handle null/undef members in array [Checkin: Comment 3 & 7]

This is kind of an edge case, but if an interface doesn't exist when accessed via Components.interfaces.nsIFoo, we'll get undef in the array; generateQI will then blow up when it tries to do "i.name".

This happened when building the extension manager but with --disable-xpinstall; the EM .js file has generateQI([Ci.nsIXPIBlah]) where nsIXPIBlah was an xpinstall interface, and caused a blow up.

This patch just walks through the array and only adds non-null/undef names to the array for the call to makeQI.

Comment 1

[Robert Sayre]

Comment on attachment 361435 [details] [diff] [review]
make generateQI handle null/undef members in array
[Checkin: Comment 3 & 7]

should still be a one-liner, though.

js> var interfaces = [{"name":"foo"}, null, {"name":"bar"}, undefined, {"name":"baz"}]
js> var x = [i.name for each (i in interfaces) if (i)]                                 
js> x.length
3
js> x
foo,bar,baz
js>

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Man, that's starting to look like perlesque line noise ;)

Sounds good though, will update.

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Checked in with the one-liner, 0ce096d6b9df

Comment 4

[Serge Gautherie (:sgautherie)]

Comment on attachment 361435 [details] [diff] [review]
make generateQI handle null/undef members in array
[Checkin: Comment 3 & 7]

Can't hurt, and would help bug 484579 comment 33 for example.

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 361435 [details] [diff] [review]
make generateQI handle null/undef members in array
[Checkin: Comment 3 & 7]

a191=beltzner

Comment 7

[Serge Gautherie (:sgautherie)]

Comment on attachment 361435 [details] [diff] [review]
make generateQI handle null/undef members in array
[Checkin: Comment 3 & 7]


http://hg.mozilla.org/releases/mozilla-1.9.1/rev/aeffb6e8a4cc