477751 - Attempting to drag item from bookmarks toolbar overflow menu results in entire window moving

Status: VERIFIED FIXED

(Toolkit :: Toolbars and Toolbar Customization, defect)

Description

[Jesse Ruderman]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090209 Minefield/3.2a1pre

Steps to reproduce:
1. Make sure you have enough bookmarks toolbar items to create an overflow menu.  (Or make your window skinny.)
2. Click the overflow button.
3. Try to drag an item from the overflow menu to the bookmarks toolbar.

Result: The entire window moved, as if it thinks the menu item is an empty part of a unified toolbar.

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Cannot reproduce on Windows, will check on Mac

Comment 2

[Markus Stange [:mstange]]

This is a direct regression from bug 398928. We're checking the element that the mouse is over using event.target, but that doesn't seem to include anonymous XBL generated elements. (The overflow menu is inserted by the "places-bar" binding.)

I don't know how to fix this.

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

could you check if you are dragging an item in a menupopup? i doubt that's a valid drag case for a window

Comment 4

[Dão Gottwald [:dao]]

(In reply to comment #2)
> This is a direct regression from bug 398928. We're checking the element that
> the mouse is over using event.target, but that doesn't seem to include
> anonymous XBL generated elements.

event.originalTarget can be an anonymous element.

Comment 5

[Markus Stange [:mstange]]

Attachment: fix

Great.

Comment 6

[Markus Stange [:mstange]]

pushed: http://hg.mozilla.org/mozilla-central/rev/c9166525952d

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified fixed with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090213 Minefield/3.2a1pre ID:20090213020442

Markus, can we ask for approval1.9.1?

Comment 8

[Markus Stange [:mstange]]

pushed to 1.9.1: http://hg.mozilla.org/releases/mozilla-1.9.1/rev/9fe3e9c7e44f

Comment 9

[Marcia Knous [:marcia]]

Verified fixed on the 1.9.1 branch using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3pre) Gecko/20090217 Firefox. Adding keyword.