477785 - Remove MIR entirely now that nanojit is default for all jit platforms

Status: VERIFIED FIXED

(Tamarin Graveyard :: Baseline JIT (CodegenLIR), defect)

Description

[Edwin Smith]

also remove any resulting dead code, like GrowableBuffer

Comment 1

[Rick Reitmaier]

Added solaris nanojit implementation bug int the dep. list.  Feel free to remove it if its not considered a blocker for this item.

Comment 2

[Rick Reitmaier]

You'll probably come across these but just pointing them out...in avmcore xxxMirBuffer calls and in GCHeap there are codeMemory routines that would be candidates for removal.

Comment 3

[Edwin Smith]

(In reply to comment #1)
> Added solaris nanojit implementation bug int the dep. list.  Feel free to
> remove it if its not considered a blocker for this item.

I don't consider Sparc to be a blocker because the MIR sparc code has bitrotted.  However that bug is now closed, so the point is moot.

Comment 4

[Edwin Smith]

Attachment: removes code guarded by AVMPLUS_MIR

Comment 5

[Edwin Smith]

more patches coming, to rename a few api's, and remove the Mir specific code in MMgc.  (some are questionable, depending on what we need for nanojit page protection).

Comment 6

[Rick Reitmaier]

Comment on attachment 362975 [details] [diff] [review]
removes code guarded by AVMPLUS_MIR

Goodbye MIR we hardly knew ye! Oh...actually, we knew ya well enough.

Probably already known but just pointing out that merging with flash player will require a minor changes (e.g. dceopt)

Also, regarding the mmgc changes, I think we should pull that code and implement whatever support is needed within nanojit and VMPI...but that should be a separate bug/discussion.

Comment 7

[Edwin Smith]

Comment on attachment 362975 [details] [diff] [review]
removes code guarded by AVMPLUS_MIR

http://hg.mozilla.org/tamarin-redux/rev/f2ae8b49c0b5

Comment 8

[Edwin Smith]

Attachment: rename api's to not reference MIR

Comment 9

[Edwin Smith]

Attachment: remove MirMemory and CodeMemory stuff from MMgc

Comment 10

[Rick Reitmaier]

Comment on attachment 363372 [details] [diff] [review]
rename api's to not reference MIR

We should check that -Dforcemir is not used by the build system/test harness.

Comment 11

[Edwin Smith]

Comment on attachment 363372 [details] [diff] [review]
rename api's to not reference MIR

pushed http://hg.mozilla.org/tamarin-redux/rev/bcce1a87b353

Comment 12

[Tommy Reilly]

Was GrowableBuffer supposed to die with this change?

Comment 13

[Edwin Smith]

yes, but not FEATURE_BUFFER_GUARD, yet.  (see bug 476497).  point me to any more dead code and i'll take care of it.

Comment 14

[Brent Baker]

removing QRB request, bug resolved/verified